Add sssom #145
Draft
Add sssom #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbizon
approved these changes
Aug 18, 2022
|
This now build via Docker |
|
Tiny comment, you can use the sssom validator to check whether outputted sssom is correctly formatted see here for an example of that: https://github.com/mapping-commons/mh_mapping_initiative/pull/24/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R20 Your currently committed sssom example is conformant to a quite old version of sssom, while you include a more recent (maybe update that as well) sssom toolkit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes both the Rust code to convert *.sssom.tsv data into the legacy format and a new function to parse the *.sssom.tsv directly using the sssom library.