from_pretrained has correct return type (i.e. HookedSAETransformer.from_pretrained returns HookedSAETransformer)
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the type signature of
from_pretrained, so its return type is the generic type of the base class. For example, now when we useHookedSAETransformer.from_pretrained, the expected return type isHookedSAETransformernotHookedTransformer.I changed this because in my SAE intro material I was having to explicitly type-annotate as
sae: HookedSAETransformer = HookedSAETransformer.from_pretrained(...), and so just changing the type signature seemed like the best option.