Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cr52 serial ethernet drivers #150

Merged
merged 24 commits into from
Nov 16, 2023

Conversation

fsylvestre
Copy link
Contributor

Add two drivers (following the new architecture): both are for spider/CR52 Renesas platforms.

  • Serial driver
  • Ethernet driver (based on lwip stack)

@fsylvestre fsylvestre force-pushed the fsylvestre/add_cr52_serial_ethernet_drivers branch from e786215 to 7ed5841 Compare November 13, 2023 15:14
@fsylvestre fsylvestre marked this pull request as draft November 13, 2023 15:18
@fsylvestre fsylvestre force-pushed the fsylvestre/add_cr52_serial_ethernet_drivers branch from 7ed5841 to 742f782 Compare November 13, 2023 15:26
@fsylvestre fsylvestre marked this pull request as ready for review November 13, 2023 15:34
@jlbirccyn
Copy link
Member

Hi Florian.

A first remark about the added examples. OIL_VERSION 4.2 does not exist.

fsylvestre and others added 24 commits November 15, 2023 14:33
Interrupt numbers were taken from MCAL code and checked against
the excel file with the full list of interrupts, so numbers should
be quite reliable.

Signed-off-by: Valerio Setti <[email protected]>
This include:

- CR52 initialization taken from MCAL
- serdes initialization taken from MCAL and compared against the
  User Manual

Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
A sample task is also added which simply echoes back the data
that it receives.

Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
PING works in this state.
Note: IP address is fixed at 192.168.1.2

Signed-off-by: Valerio Setti <[email protected]>
@fsylvestre fsylvestre force-pushed the fsylvestre/add_cr52_serial_ethernet_drivers branch from 742f782 to 4d0063f Compare November 15, 2023 13:34
@fsylvestre
Copy link
Contributor Author

Hi Florian.

A first remark about the added examples. OIL_VERSION 4.2 does not exist.

Ok, it should be fixed now

@jlbirccyn jlbirccyn self-requested a review November 16, 2023 09:09
Copy link
Member

@jlbirccyn jlbirccyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can me merged. 2 remarks however.

  1. The build.sh script in examples calls goil and ./make.py. However make.py would call goil if the oil file is modified. It is not a problem to call goil each time except all generated files will be compiled again. Normally, goil is called once and then simply call make.py after a change in source files the oil one included.
  2. variables are not declared using AUTOSAR macro. They should be, so that the source file is an AUTOSAR-compliant file.

@RICCIARDI-Adrien RICCIARDI-Adrien merged commit 7952a97 into master Nov 16, 2023
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants