-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cr52 serial ethernet drivers #150
Merged
RICCIARDI-Adrien
merged 24 commits into
master
from
fsylvestre/add_cr52_serial_ethernet_drivers
Nov 16, 2023
Merged
Add cr52 serial ethernet drivers #150
RICCIARDI-Adrien
merged 24 commits into
master
from
fsylvestre/add_cr52_serial_ethernet_drivers
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsylvestre
force-pushed
the
fsylvestre/add_cr52_serial_ethernet_drivers
branch
from
November 13, 2023 15:14
e786215
to
7ed5841
Compare
fsylvestre
force-pushed
the
fsylvestre/add_cr52_serial_ethernet_drivers
branch
from
November 13, 2023 15:26
7ed5841
to
742f782
Compare
Hi Florian. A first remark about the added examples. OIL_VERSION 4.2 does not exist. |
Interrupt numbers were taken from MCAL code and checked against the excel file with the full list of interrupts, so numbers should be quite reliable. Signed-off-by: Valerio Setti <[email protected]>
This include: - CR52 initialization taken from MCAL - serdes initialization taken from MCAL and compared against the User Manual Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
A sample task is also added which simply echoes back the data that it receives. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
PING works in this state. Note: IP address is fixed at 192.168.1.2 Signed-off-by: Valerio Setti <[email protected]>
… requests on every IP addresses
fsylvestre
force-pushed
the
fsylvestre/add_cr52_serial_ethernet_drivers
branch
from
November 15, 2023 13:34
742f782
to
4d0063f
Compare
Ok, it should be fixed now |
jlbirccyn
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one can me merged. 2 remarks however.
- The build.sh script in examples calls
goil
and./make.py
. Howevermake.py
would callgoil
if the oil file is modified. It is not a problem to call goil each time except all generated files will be compiled again. Normally,goil
is called once and then simply call make.py after a change in source files the oil one included. - variables are not declared using AUTOSAR macro. They should be, so that the source file is an AUTOSAR-compliant file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two drivers (following the new architecture): both are for spider/CR52 Renesas platforms.