Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): import paths for svg assets #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(select): import paths for svg assets #501

wants to merge 1 commit into from
+5 −3

Conversation

nguyenlam123
Copy link

  • I am not sure if it's possible to use named imports for assets but I do know that default imports like the code changes below work.

Behaviour before merging this PR when running npm start locally
ts-select-broken

Behaviour after merging this PR when running npm start locally
ts-select-fixed

@nguyenlam123 nguyenlam123 requested a review from a team as a code owner August 17, 2022 17:04
@ts-sonarqube
Copy link

ts-sonarqube bot commented Aug 17, 2022

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • No coverage informationNo coverage information (0.00% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (2.20% Estimated after merge)

Project ID: elements

View in SonarQube

@nguyenlam123
Copy link
Author

nguyenlam123 commented Aug 17, 2022 •
edited
Loading

Please do help me verify this on your local machine. Does the arrowDownShort disappear when you run it locally without my code changes? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nguyenlam123