Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide health bars for armor stands and invisible entities that aren't glowing #116

Conversation

Njol
Copy link

@Njol Njol commented Jul 28, 2021

Armor stands should not have health bars, see PR #61.

Invisible entities also should not have health bars, see issue #86. The health bar of invisible entities is shown if they are glowing though, as the glowing effect makes them (partially) visible again.

Since there is no branch for 1.16.5 this PR targets 1.16.3.

@frodare
Copy link
Member

frodare commented Jul 28, 2021

Please rebase this into a single commit off of commit 9d7af0f.

@Njol
Copy link
Author

Njol commented Jul 29, 2021

This would be a single commit if there was a branch for 1.16.5 that this PR could target. It is based on the commit just before (0e3e1a1).
By creating a branch at say commit 9d7af0f and retargetting this PR only one commit will show here.

@frodare
Copy link
Member

frodare commented Jul 30, 2021

I have created a 1.16.5 branch you can target.

@Njol Njol changed the base branch from fabric-1.16.3 to fabric-1.16.5 July 30, 2021 11:42
@Njol
Copy link
Author

Njol commented Jul 30, 2021

Great, I edited all my PRs to target the new branch.

@frodare frodare merged commit c662ce4 into ToroCraft:fabric-1.16.5 Jul 31, 2021
@frodare
Copy link
Member

frodare commented Aug 1, 2021

I finally got time to build and deploy your fixes. Thanks for your help! I am releasing the changes from this PR and the others as torohealth-1.16.5-fabric-6.jar. I am thinking some of these changes might help the optifine problems in the 1.17.1 build too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants