Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure context types and add AggregateOffer #71

Open
wants to merge 6 commits into
base: 1.0.0
Choose a base branch
from

Conversation

madman-81
Copy link

  1. Create new auto inherit structure for context attributes ($structure). Attributes in the $structure property are now automatically merged with all parent classes
  2. The setProperty() function has been renamed to makeProperty() and the actual setting of properties is now down inside the fill() function. This makes for easier unit testing in the future.
  3. The makeProperty() is also able to handle nested contexts better:
  • If the $value contains @type, it will create a contact based on that type
  • $property can now contain an array of classes defining what types of nexted context may be used for that attribute of the main context
  • If $value hold and array of contexts, it will automatically make contexts for those. This was done in several context with a setter, these are now all obsolete and therefore removed
  1. The Music related contexts have be reorganised and the mutual attributes have been moved to MusicAbstractContext
  2. Restructure existing contexts and make the match the hierarchy of schema.org
  3. Add PHPUnit config for code coverage
  4. Add Json extension to the list of required packages
  5. Add AggregateOffer

Solving #70, #68, #63, #49 and #27
And probably also #62,

…. Attributes in the $structure property are now automatically merged with all parent classes
…he actual setting of properties is now down inside the fill() function. This makes for easier unit testing in the future.

* The makeProperty() is also able to handle nested contexts better.
 - If the $value contains @type, it will create a contact based on that type
 - $property can now contain an array of classes defining what types of nexted context may be used for that attribute of the main context
 - If $value hold and array of contexts, it will automatically make contexts for those. This was done in several context with a setter, these are now all obsolete and therefore removed
* The Music related contexts have be reorganised and the mutual attributes have been moved to MusicAbstractContext
@madman-81
Copy link
Author

This also covers pull requests #67 and #64 making those obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant