Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DAPP-419): shows certain chains on dev only #40

Merged
merged 17 commits into from
Dec 13, 2023
Merged

feat(DAPP-419): shows certain chains on dev only #40

merged 17 commits into from
Dec 13, 2023

Conversation

Kelz29
Copy link
Contributor

@Kelz29 Kelz29 commented Nov 29, 2023 •
edited
Loading

Description

shows certain chains on dev only

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Kelz29 Kelz29 added the enhancement New feature or request label Nov 29, 2023
@Kelz29 Kelz29 self-assigned this Nov 29, 2023
@lukorito
Merge pull request #39 from Topl/DAPP-363
2f44686 
DAPP-363: Select Network Initial Tests
KalervoHyyppa
KalervoHyyppa approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@KalervoHyyppa KalervoHyyppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kelz29 Kelz29 merged commit 53b83c2 into dev Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalervoHyyppa KalervoHyyppa KalervoHyyppa approved these changes

@lukorito lukorito Awaiting requested review from lukorito

@berriose berriose Awaiting requested review from berriose

Assignees

@Kelz29 Kelz29

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kelz29 @KalervoHyyppa @lukorito