Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAPP 390 & DAPP 389: Failed request test for mobile and tablet #30

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

lukorito
Copy link
Contributor

@lukorito lukorito commented Nov 8, 2023

Description

Add failed request test for mobile and tablet
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have added screenshots

@@ -12,3 +12,16 @@ class RequiredRequestsTests extends RequiredTest {
await menuOpened(testScreenSize);
}
}

class RequiredInvalidRequestsTests extends RequiredTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should split the success and failure tests or keep them in the same RequiredTests class.

Copy link
Contributor

@KalervoHyyppa KalervoHyyppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukorito lukorito merged commit 99e8a01 into dev Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants