Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datacardMaker to make IM scalings #434

Merged
merged 16 commits into from
Dec 10, 2024
Merged

Update datacardMaker to make IM scalings #434

merged 16 commits into from
Dec 10, 2024

Conversation

ywan2
Copy link
Contributor

@ywan2 ywan2 commented Oct 3, 2024

Multiple scripts were edited:

  1. datacard_tools.py & make_cards.py:
  • calling functions make_scalings_content() and make_scalings()in histEFT (see topcoffea PR47) to make scalings.json file for interference model
  1. datacard_post_processing.py:
  • sort the necessary channels needed in the analysis and remove extra dictionaries.
  1. fullR2_run.sh:
  • add --wc-list with ordered wcs needed for IM.

Copy link
Contributor

@bryates bryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ywan2, my comments are minor.

analysis/topeft_run2/fullR2_run.sh Outdated Show resolved Hide resolved
analysis/topeft_run2/run_analysis.py Outdated Show resolved Hide resolved
@bryates
Copy link
Contributor

bryates commented Oct 31, 2024

@ywan2 is there anything in this PR that needs to be updated after merging TopEFT/topcoffea#49?

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.

Project coverage is 26.72%. Comparing base (3d3ad9d) to head (0e016ed).
Report is 48 commits behind head on master.

Files with missing lines Patch % Lines
analysis/topeft_run2/datacards_post_processing.py 0.00% 16 Missing ⚠️
topeft/modules/datacard_tools.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   26.58%   26.72%   +0.14%     
==========================================
  Files          31       31              
  Lines        4612     4651      +39     
==========================================
+ Hits         1226     1243      +17     
- Misses       3386     3408      +22     
Flag Coverage Δ
unittests 26.72% <58.13%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ywan2
Copy link
Contributor Author

ywan2 commented Nov 18, 2024

@ywan2 is there anything in this PR that needs to be updated after merging TopEFT/topcoffea#49?

There is no conflict in the branch regarding merging this topcoffea PR.

@bryates bryates self-requested a review December 10, 2024 17:07
@bryates bryates merged commit 6555c78 into master Dec 10, 2024
4 checks passed
@bryates bryates deleted the AAC-Interference branch December 10, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants