-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datacardMaker to make IM scalings #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ywan2, my comments are minor.
@ywan2 is there anything in this PR that needs to be updated after merging TopEFT/topcoffea#49? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 26.58% 26.72% +0.14%
==========================================
Files 31 31
Lines 4612 4651 +39
==========================================
+ Hits 1226 1243 +17
- Misses 3386 3408 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There is no conflict in the branch regarding merging this topcoffea PR. |
Multiple scripts were edited:
make_scalings_content()
andmake_scalings()
in histEFT (see topcoffea PR47) to make scalings.json file for interference model--wc-list
with ordered wcs needed for IM.