Updating AAC to work with combine v9 (CMSSW 11x and greater) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pulled these changes and ran a 1D scan on Top-22-006 workspace, and I am seeing that for all the scan points, the deltaNLL values are 0 (very small of the order of 10^-10). This is similar to what I observed previously. Could something be broken with combine instead? |
It seems unlikely that combine would be broke, but we can try to think of some other tests to run. I'll try going through this model to see if anything stands out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated AAC model that should work with newer versions of combine and CMSSW.