Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previously ignored errors when fetching ToolDAQFramework #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jini-zh
Copy link

@jini-zh jini-zh commented Feb 17, 2023

Fix zeromq complains during make install phase.
Do not build Boost.Python --- does not compile against python-3.10.9 and not used in this project.
Enable error handling in GetToolDAQ.sh.

@jini-zh
Copy link
Author

jini-zh commented Feb 28, 2023

Regarding the failing CI tests:

  1. Builds on centos-latest fail because while installing prerequisites, yum fails to download repository information. Apparently, this is related to CentOS 8 reaching end of life in 2022, see https://www.centos.org/centos-linux-eol/. One solution might be adding the following command in the beginning of "prerequisits" stage:
    sed -i '/^#baseurl=/{s,#,,; s,mirror,vault,}' /etc/yum.repo.d/*

With it, GetToolDAQ.sh worked as expected.

  1. The build on centos_7 fails because the archive it uses doesn't have the .git directory, and git add ... at the end of GetToolDAQ.sh fails. There is a message at line 18 in "Run actions/checkout@v2":

To create a local Git repository instead, add Git 2.18 or higher to the PATH

It can be fixed by moving the "prerequisits" stage one step up, so that it runs before "Run actions/checkout@v2". Another approach is to let git add ... fail and not treat it as an error in GetToolDAQ.sh. It happens at the end of the installation just before the cleanup, when everything is done anyway. Should I do the latter?

jini-zh pushed a commit to jini-zh/ToolApplication that referenced this pull request Jul 24, 2024
Implement readout from the beam system cards
Evgenii Zhemchugov added 3 commits August 13, 2024 12:20
Otherwise `install` complains about `include/zmq.h` and
`include/zmq_utils.h` being both source and destination and `make
install` fails.
Fails to compile against python-3.10.9, and not used in this project.
@jini-zh
Copy link
Author

jini-zh commented Aug 13, 2024

These commits are still relevant although I admit not very important. CentOS 7 build now fails with a different reason, apparently the docker container is too outdated for the Github's integration system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant