Skip to content

Commit

Permalink
added bulk in close API tests, description of PR to changelog, deleti…
Browse files Browse the repository at this point in the history
…ng comment and temporary ci setting

Signed-off-by: Tokesh <[email protected]>
  • Loading branch information
Tokesh committed Jul 24, 2024
1 parent 0c29ed7 commit 8514dfd
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 35 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

- name: Run Tests
run: |
npm run test:spec -- --opensearch-insecure --verbose --coverage coverage/test-spec-coverage-${{ matrix.entry.version }}.json
npm run test:spec -- --opensearch-insecure --coverage coverage/test-spec-coverage-${{ matrix.entry.version }}.json
- name: Upload Test Coverage Results
uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Added AjvErrorsParser to print more informative error messages ([#364](https://github.com/opensearch-project/opensearch-api-specification/issues/364))
- Added JsonSchemaValidator, a wrapper for AJV ([#364](https://github.com/opensearch-project/opensearch-api-specification/issues/364))
- Added support for `application/cbor` responses ([#371](https://github.com/opensearch-project/opensearch-api-specification/pull/371))
- Added tests for SQL namespace ([#379](https://github.com/opensearch-project/opensearch-api-specification/pull/379))
- Added support for `application/smile` responses ([#386](https://github.com/opensearch-project/opensearch-api-specification/pull/386))
- Added `doc_status`, `remote_store`, `segment_replication` and `unreferenced_file_cleanups_performed` to `SegmentStats` ([#395](https://github.com/opensearch-project/opensearch-api-specification/pull/395))
- Added `concurrent_query_*` and `search_idle_reactivate_count_total` fields to `SearchStats` ([#395](https://github.com/opensearch-project/opensearch-api-specification/pull/395))
Expand Down
2 changes: 1 addition & 1 deletion spec/namespaces/sql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ paths:
operationId: sql.close.0
x-operation-group: sql.close
x-version-added: '1.0'
description: Clears the cursor context.
description: Clear the cursor context.
externalDocs:
url: https://opensearch.org/docs/latest/search-plugins/sql/sql-ppl-api/
parameters:
Expand Down
15 changes: 1 addition & 14 deletions spec/schemas/sql._common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,4 @@ components:
user:
type: object
execution_time:
type: object
# SqlStatsResponse:
# type: object
# properties:
# request_total:
# type: integer
# request_count:
# type: integer
# failed_request_count_syserr:
# type: integer
# failed_request_count_cuserr:
# type: integer
# failed_request_count_cb:
# type: integer
type: object
26 changes: 7 additions & 19 deletions tests/sql/close.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,16 @@ epilogues:
method: DELETE
status: [200, 404]
chapters:
- synopsis: Create a document.
path: /{index}/_doc
- synopsis: Create few documents.
path: /_bulk
method: POST
parameters:
index: books
request_body:
content_type: application/x-ndjson
payload:
title: Beauty and the Beast
year: 1991
response:
status: 201
- synopsis: Create a document.
path: /{index}/_doc
method: POST
parameters:
index: books
request_body:
payload:
title: To name the bigger life
year: 2004
response:
status: 201
- {create: {_index: books, _id: book_1392214}}
- {author: Harper Lee, title: To Kill a Mockingbird, year: 1960}
- {create: {_index: books, _id: book_1392215}}
- {author: Elizabeth Rudnick, title: Beauty and the Beast, year: 1991}

Check failure on line 26 in tests/sql/close.yaml

View workflow job for this annotation

GitHub Actions / lint

Unknown word: "Rudnick"
- synopsis: Refresh the index.
path: /{index}/_refresh
method: POST
Expand Down

0 comments on commit 8514dfd

Please sign in to comment.