adding specs and tests for SQL Settings API

Signed-off-by: Tokesh <[email protected]>

CHANGELOG.md

@@ -36,7 +36,6 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Added JsonSchemaValidator, a wrapper for AJV ([#364](https://github.com/opensearch-project/opensearch-api-specification/issues/364))
 - Added support for `application/cbor` responses ([#371](https://github.com/opensearch-project/opensearch-api-specification/pull/371))
 - Added `/_plugins/_sql`, `close`, `explain` and `stats` ([#379](https://github.com/opensearch-project/opensearch-api-specification/pull/379))
-- Added tests for SQL namespace ([#379](https://github.com/opensearch-project/opensearch-api-specification/pull/379))
 - Added support for `application/smile` responses ([#386](https://github.com/opensearch-project/opensearch-api-specification/pull/386))
 - Added `doc_status`, `remote_store`, `segment_replication` and `unreferenced_file_cleanups_performed` to `SegmentStats` ([#395](https://github.com/opensearch-project/opensearch-api-specification/pull/395))
 - Added `concurrent_query_*` and `search_idle_reactivate_count_total` fields to `SearchStats` ([#395](https://github.com/opensearch-project/opensearch-api-specification/pull/395))

spec/_superseded_operations.yaml

@@ -586,7 +586,7 @@ $schema: ./json_schemas/_superseded_operations.schema.yaml
   operations:
     - POST
 /_opendistro/_sql/settings:
-  superseded_by: /_plugins/_sql/settings
+  superseded_by: /_plugins/_query/settings
   operations:
     - PUT
 /_opendistro/_sql/stats:

spec/namespaces/sql.yaml

@@ -4,6 +4,21 @@ info:
   description: OpenSearch SQL API
   version: 1.0.0
 paths:
+  /_plugins/_query/settings:
+    put:
+        operationId: sql.settings.0
+        x-operation-group: sql.settings
+        x-version-added: '1.0'
+        description: Adds SQL settings to the standard OpenSearch cluster settings.
+        externalDocs:
+          url: https://opensearch.org/docs/latest/search-plugins/sql/settings/
+        parameters:
+          - $ref: '#/components/parameters/sql.settings::query.format'
+        requestBody:
+          $ref: '#/components/requestBodies/sql.settings'
+        responses:
+          '200':
+            $ref: '#/components/responses/sql.settings@200'
   /_plugins/_sql:
     post:
       operationId: sql.query.0
@@ -83,6 +98,13 @@ paths:
           $ref: '#/components/responses/sql.post_stats@200'
 components:
   parameters:
+    sql.settings::query.format:
+      name: format
+      in: query
+      description: A short version of the Accept header, e.g. json, yaml.
+      schema:
+        type: string
+        description: A short version of the Accept header, e.g. json, yaml.  
     sql.query::query.format:
       name: format
       in: query
@@ -159,6 +181,12 @@ components:
         default: true
         description: Specifies whether to escape special characters in the results
   requestBodies:
+    sql.settings:
+      content:
+        application/json:
+          schema:
+            $ref: '../schemas/sql._common.yaml#/components/schemas/SqlSettings'
+      required: true
     sql.query:
       content:
         application/json:
@@ -184,6 +212,12 @@ components:
             $ref: '../schemas/sql._common.yaml#/components/schemas/SqlStats'
       required: true
   responses:
+    sql.settings@200:
+      description: ''
+      content:
+        application/json:
+          schema:
+            $ref: '../schemas/sql._common.yaml#/components/schemas/SqlSettingsResponse'
     sql.query@200:
       description: ''
       content:

spec/schemas/sql._common.yaml

@@ -85,4 +85,48 @@ components:
         user:
           type: object
         execution_time:
-          type: object
+          type: object
+    SqlSettings:
+      type: object
+      properties:
+        transient:
+          $ref: '#/components/schemas/Transient'
+    SqlSettingsResponse:
+      type: object
+      properties:
+        acknowledged:
+          type: boolean
+        persistent:
+          type: object
+        transient:
+          $ref: '#/components/schemas/Transient'
+    Transient:
+      type: object
+      properties:
+        plugins:
+          type: object
+          properties:
+            ppl:
+              type: object
+              properties:
+                enabled:
+                  type: string
+            query:
+              type: object
+              properties:
+                memory_limit:
+                  type: string
+                size_limit:
+                  type: string
+            sql:
+              type: object
+              properties:
+                enabled:
+                  type: string
+                slowlog:
+                  type: string
+                cursor:
+                  type: object
+                  properties:
+                    keep_alive:
+                      type: string

tests/sql/query.yaml

@@ -17,6 +17,8 @@ chapters:
   - synopsis: Get SQL query
     path: /_plugins/_sql
     method: POST
+    parameters:
+      sanitize: false
     request_body:
       payload:
         query: 'SELECT * FROM books'

tests/sql/settings.yaml

@@ -0,0 +1,24 @@
+$schema: ../../json_schemas/test_story.schema.yaml
+
+description: Test updating SQL settings in OS cluster.
+
+chapters:
+  - synopsis: Update SQL settings.
+    path: /_plugins/_query/settings
+    method: PUT
+    request_body:
+      payload:
+        transient: 
+          plugins:
+            sql:
+              enabled: 'true'
+              slowlog: '2'
+              cursor:
+                keep_alive: "1m"
+            ppl:
+              enabled: 'true'
+            query:
+              memory_limit: "80%"
+              size_limit: "200"
+    response:
+      status: 200