VDOC Launch for realises #116
Conversation
|
... meant to do that in our own fork SORRY!! |
|
No worries @RickyCook Just to note that the approach you are doing the whitelisting is less elegant than using signatures in the transactions. You are now polluting Ethereum state with the whitelist status. This does not need to be the case as you know at the time of the payment if the person is whitelisted or not (you have this information in your database). |
|
yeah, I totally agree! I love the "stateless login" things similar to JWT. though, we made a decision that we wanted people to be able to pay direct to the contract without adding any transaction data, so the only way that we were able to do that is eschew all the customer ID stuff and tie them to eth addresses. it's less elegant, but much much simpler. and if you're wondering, no the fallback function wasn't included in this PR; I raised it early for review purposes! that being said, is there any reason why your fallback function just does a throw? I would've thought it'd be better to call buy and then have buy throw if it needed more information? |
|
@RickyCook I feel you made a wrong choice.
https://tokenmarket.net/what-is/how-to-buy-into-a-token-sale-with-metamask-wallet/ "Without any transaction data" is against the core principles of smart contracts - by not addressing the fact that smart contracts have functions make the contract quite dumb in the end. |
|
@RickyCook how do you transfer eth to smart contract successfully without adding transact data. Between, I tried to send ETH to crowdsale address using myethwallet.com by connecting meta mask but its still showing error and transaction failed. Any advice would be much appreciatable. |
No description provided.