Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use vcpkg instead of conan in the MSVC build. #2797

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 21, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Nov 21, 2024
@github-actions github-actions bot added the chore Updating grunt tasks etc; no production code change label Nov 21, 2024
@iphydf iphydf force-pushed the vcpkg branch 5 times, most recently from c9b2aa1 to 3190840 Compare November 21, 2024 11:54
@Green-Sky
Copy link
Member

vcpkg is not windows exclusive, so naming should reflect that.

@iphydf iphydf marked this pull request as ready for review November 21, 2024 17:04
Copy link
Member

@Green-Sky Green-Sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess its fine, since this is azure only.

@toktok-releaser toktok-releaser merged commit 1dc399b into TokTok:master Nov 21, 2024
62 checks passed
@iphydf iphydf deleted the vcpkg branch November 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Updating grunt tasks etc; no production code change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants