Add media wiki platform and hivemind support #169
Conversation
WalkthroughThe changes involve transitioning from hardcoded string literals to enum values across various test files, interfaces, and schemas. This ensures improved type safety and consistency in the codebase. Enum values from the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (12)
- tests/unit/models/module.model.test.ts (3 hunks)
- tests/unit/models/platform.model.test.ts (2 hunks)
- tests/unit/models/token.model.test.ts (3 hunks)
- package.json (1 hunks)
- src/config/enums.ts (1 hunks)
- src/index.ts (1 hunks)
- src/interfaces/Module.interface.ts (2 hunks)
- src/interfaces/Platfrom.interface.ts (1 hunks)
- src/interfaces/Token.interface.ts (1 hunks)
- src/models/schemas/Module.schema.ts (2 hunks)
- src/models/schemas/Platform.schema.ts (1 hunks)
- src/models/schemas/Token.schema.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- package.json
- src/index.ts
Additional comments not posted (27)
src/interfaces/Token.interface.ts (2)
2-2: The import statement correctly importsTokenTypeNamesfrom the enums file.
7-7: Thetypeproperty in theITokeninterface is updated to useTokenTypeNames, enhancing type safety.src/interfaces/Platfrom.interface.ts (3)
2-2: The import statement correctly importsPlatformNamesfrom the enums file.
5-5: Thenameproperty in theIPlatforminterface is updated to usePlatformNames, enhancing type safety.
13-13: Thenameproperty in theIPlatformUpdateBodyinterface is updated to usePlatformNames, enhancing type safety.src/models/schemas/Token.schema.ts (2)
4-4: The import statement correctly importsTokenTypeNamesfrom the enums file.
20-20: Thetypefield in the schema is updated to useObject.values(TokenTypeNames), enhancing type safety.src/interfaces/Module.interface.ts (4)
2-2: The import statement correctly importsModuleNamesandPlatformNamesfrom the enums file.
5-5: Thenameproperty in theIModuleinterface is updated to useModuleNames, enhancing type safety.
10-10: Thenameproperty in theoptions.platformsarray is updated to usePlatformNames, enhancing type safety.
19-19: Thenameproperty in theoptions.platformsarray in theIModuleUpdateBodyinterface is updated to usePlatformNames, enhancing type safety.src/config/enums.ts (3)
1-8: ThePlatformNamesenum is defined correctly, providing a clear and type-safe way to handle platform names.
10-12: TheModuleNamesenum is defined correctly, providing a clear and type-safe way to handle module names.
22-32: TheTokenTypeNamesenum is defined correctly, providing a clear and type-safe way to handle token types.__tests__/unit/models/module.model.test.ts (3)
4-4: The import statement correctly importsModuleNamesandPlatformNamesfrom the enums file.
15-15: Thenameproperty in the test case is updated to useModuleNames.Hivemind, enhancing type safety.
24-24: Thenameproperty in theoptions.platformsarray in the test case is updated to usePlatformNames.Discord, enhancing type safety.src/models/schemas/Module.schema.ts (3)
4-4: The import statement correctly importsModuleNamesandPlatformNamesfrom the enums file.
11-11: Thenamefield in the schema is updated to useObject.values(ModuleNames), enhancing type safety.
32-32: Thenamefield in theoptions.platformsarray in the schema is updated to useObject.values(PlatformNames), enhancing type safety.__tests__/unit/models/token.model.test.ts (3)
5-5: The import statement correctly importsTokenTypeNamesfrom the enums file.
14-14: Thetypeproperty in the test case is updated to useTokenTypeNames.GOOGLE_REFRESH, enhancing type safety.
24-30: The test case correctly validates an invalid token type, ensuring robustness.src/models/schemas/Platform.schema.ts (2)
5-5: Import statement looks good.
12-12: UsingObject.values(PlatformNames)for thenamefield enum improves type safety and consistency.__tests__/unit/models/platform.model.test.ts (2)
4-4: Import statement looks good.
14-14: UsingPlatformNames.Googlefor thenameproperty in the test setup improves type safety and consistency.
src/config/enums.ts
Outdated
| export enum HivemindPlatforNames { | ||
| Discord = 'discord', | ||
| Google = 'google', | ||
| GitHub = 'github', | ||
| Notion = 'notion', | ||
| MediaWiki = 'mediaWiki', | ||
| } |
There was a problem hiding this comment.
There is a typo in the enum name HivemindPlatforNames. It should be HivemindPlatformNames.
- export enum HivemindPlatforNames {
+ export enum HivemindPlatformNames {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| export enum HivemindPlatforNames { | |
| Discord = 'discord', | |
| Google = 'google', | |
| GitHub = 'github', | |
| Notion = 'notion', | |
| MediaWiki = 'mediaWiki', | |
| } | |
| export enum HivemindPlatformNames { | |
| Discord = 'discord', | |
| Google = 'google', | |
| GitHub = 'github', | |
| Notion = 'notion', | |
| MediaWiki = 'mediaWiki', | |
| } |
Behzad-rabiei
deleted the
add-mediaWiki-platform-and-hivemind-support
branch
Summary by CodeRabbit
New Features
Bug Fixes
Chores
package.json.