changes server and worker #80
Conversation
WalkthroughThis update involves several key changes to the application, including restructuring how Celery tasks are invoked and managed. Modifications have been made to Docker configurations, Celery app initialization, and import statements. Additionally, a new tracing function has been introduced, and logistical files for code quality tools have been updated. Changes
Poem
Tip Early access features
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
Dockerfile (1)
Line range hint
5-5: Optimize Docker build by avoiding pip cache.The static analysis tool flagged the use of pip cache. It's best to avoid this to reduce the Docker image size.
- RUN pip3 install -r requirements.txt + RUN pip3 install --no-cache-dir -r requirements.txt
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- Dockerfile (1 hunks)
- coverage/lcov.info (1 hunks)
- docker-compose.example.yml (1 hunks)
- server.py (1 hunks)
- worker/tasks.py (1 hunks)
- worker/worker.py (1 hunks)
Files not summarized due to errors (1)
- coverage/lcov.info: Error: Message exceeds token limit
Files skipped from review due to trivial changes (1)
- worker/tasks.py
Additional context used
Hadolint
Dockerfile
[warning] 5-5: Avoid use of cache directory with pip. Use
pip install --no-cache-dir <package>(DL3042)
Additional comments not posted (4)
docker-compose.example.yml (1)
8-8: Updated command for the server service in docker-compose.This change aligns with the mentioned shift in service management. Ensure that
server.pyis configured to handle being the entry point of the server service correctly.Verification successful
Updated command for the server service in docker-compose.
The
server.pyscript is correctly set up to be the entry point for the server service as it contains the necessaryif __name__ == "__main__":check.
server.pyincludes the entry point check at line 1.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify server.py handles being the entry point properly. # Test: Search for 'if __name__ == "__main__":' in server.py to confirm it's ready to be the entry point. rg --type python 'if __name__ == "__main__":' server.pyLength of output: 88
Script:
#!/bin/bash # Description: Verify server.py handles being the entry point properly. # Test: Search for 'if __name__ == "__main__":' in server.py to confirm it's ready to be the entry point. rg 'if __name__ == "__main__":' server.pyLength of output: 70
Dockerfile (1)
12-12: Updated Celery command in Dockerfile.This simplifies the invocation of Celery and aligns with the changes described in the PR summary. Ensure this new command is tested thoroughly in the Docker environment.
worker/worker.py (2)
10-10: Updated Celery app initialization to include specific tasks.This change ensures that only relevant tasks are included during the initialization, which can help in optimizing the performance and maintainability of the Celery worker.
13-14: Ensure proper execution of the Celery app when script is run directly.This change is a good practice as it prevents the Celery app from inadvertently starting when the module is imported elsewhere.
coverage/lcov.info
Outdated
| LH:21 | ||
| end_of_record | ||
| TN: | ||
| SF:bot/retrievers/process_dates.py | ||
| DA:1,1,EZEzNmL93PY96zsSuI0PfQ | ||
| DA:2,1,w4wzKKlLBqr27YH2UrIkBQ | ||
| DA:4,1,KA9tLtxJCmXGWOalg5c/zA | ||
| DA:7,1,+QD2wyYZcsC+Xvi5rjfg1w | ||
| DA:26,1,bFij5SG38wK0MWxmbT82Rw | ||
| DA:27,1,iBjZwelGAT6u9wcCT5RkQw | ||
| DA:28,1,K1+sxVnEq9jO8BqcJwVAZw | ||
| DA:29,1,pf92umTBWmtiEB1EpuczhA | ||
| DA:31,1,2uLiygcEABFP5hS6AeQwHA | ||
| DA:34,1,tYltTNWket1uI7UNICnqmw | ||
| DA:35,1,RwimGdhYyabPJL4e+Fvqnw | ||
| DA:36,1,LTTh/+NrsNUrIQkwnwP3hA | ||
| DA:37,1,Da4uV101pljkvITvb/orrw | ||
| DA:39,1,p3JK0mYGwzpZUPpV9FxrSg | ||
| DA:41,1,7mawqEbVi5mg0yRWqaqupg | ||
| LF:15 | ||
| LH:15 | ||
| end_of_record | ||
| TN: | ||
| SF:bot/retrievers/retrieve_similar_nodes.py | ||
| DA:1,1,usL6GpKXVxVT8icw7bX7uQ | ||
| DA:2,1,nuxjJx40cdYGSgrgJ50F1A | ||
| DA:4,1,KA9tLtxJCmXGWOalg5c/zA | ||
| DA:5,1,vMmpgxZJRuue6rFB1P0BSg | ||
| DA:6,1,qgap8v00S1Ud7dKp+nEVgg | ||
| DA:7,1,ZwFry2q3ybNGgdFz5V3nNw | ||
| DA:8,1,XJc56GRwdNlz7Pfca4ta2w | ||
| DA:9,1,IDxH3gjD3VSVrI4xLmrtQQ | ||
| DA:10,1,YQAIr2ESlBeDuRf0TeEF5Q | ||
| DA:11,1,2PHsUT6zqyYmFXFvARFHDg | ||
| DA:12,1,S6WdzE5Nj4jcMIr2/RIeEA | ||
| DA:15,1,IPFoc7JFmfs5ZGCvDdLKww | ||
| DA:16,1,mqoJzotpXwlnL7jkyBBK1w | ||
| DA:18,1,4LgMgWBGno1n5MNJ8WRFsQ | ||
| DA:25,1,GeCb9dZfUzto8bJsxLM/OA | ||
| DA:26,1,BOdqpSj22HMpl9h/3UQEnQ | ||
| DA:27,1,EEPdD4zi1M7G+hCfGc7kFw | ||
| DA:29,1,d+ncuJjKr272GS184mU5Mw | ||
| DA:64,1,4lzkDJLlQXSyBjO/ZBZ0tg | ||
| DA:65,1,R2Ju8xaiGLrApGDnnYA2Cw | ||
| DA:66,1,sXjQBJruC0xTKR4b+u8JIA | ||
| DA:67,1,pWP8puMbrWzJ9jyYSNijYg | ||
| DA:70,1,1DaXT/QWnDNNMkOiYOOCAg | ||
| DA:72,1,M57N117IoUfJdZ4DKcJp9w | ||
| DA:73,1,ACylfUs9k82fbh1JUVpkFw | ||
| DA:88,1,i9tYTGC/B+qp4Thp+0XtPA | ||
| DA:89,1,eJXGGDxmpnTlPApZ05Mm8w | ||
| DA:90,1,bkIDFrOGWBbeePkt6w8EJQ | ||
| DA:91,1,IDhEFBr50D3yQ1PgRwIPoQ | ||
| DA:95,1,DVM8lfdtc7XvpdnChfyzZA | ||
| DA:108,1,NYgySTsjOvX0beJFX6yMkQ | ||
| DA:109,1,87A78EES6C0LtBxGYDZtBg | ||
| DA:111,1,Dza3guFRyWWcXuaktAvUUA | ||
| DA:112,1,42k3Krouu/7c6z6xkNm7jg | ||
| DA:113,1,74cSsiTs5tJX4LFRiR9Z/A | ||
| DA:114,1,NcFv4vwj+pjug1e2Bo890w | ||
| DA:115,1,Bp6QbYpwe4PVOg8lbJA/hA | ||
| DA:116,1,jrIPKZt5zHATQ3k7gB0zMg | ||
| DA:118,1,3X+u/Gx10tHDgUlKjZ9leg | ||
| DA:119,1,enK82Bd/RAeIx81NTDQ/7w | ||
| DA:124,1,AEFyjNRKgOrooYQ/nYO/gg | ||
| DA:127,1,unkkFkVkr+wa6RT5uE8c1w | ||
| DA:132,1,HJEWWSze80ShpmLhx/FNmw | ||
| DA:137,1,SkkggBMbU32rJ3pNviGxAA | ||
| DA:142,1,XDQoFg/N3OcYqb/J4NJzUg | ||
| DA:143,1,QAy+2Mz9GQWA6hn/DfyOnw | ||
| DA:156,1,Ap+b3WevKixvNInY8BOstQ | ||
| DA:158,1,M4Wpq7+IHVDAhVO1Q+IA+w | ||
| DA:160,1,tzZodAsv3aFszptj+1OcnQ | ||
| DA:161,1,r+V3a23Womuti9fftxA7Lg | ||
| DA:165,1,e8upNNRAcwfVSEfPvxiucg | ||
| DA:167,1,FIGBJFFS77Q/1c40b8di/A | ||
| DA:168,1,NdO+Zxe21pmF6dXu3zWdMw | ||
| DA:170,1,UkwhkGz1XXrgDOp60bursg | ||
| DA:171,1,Cj+UwANUqSKqiqpqgnF9hA | ||
| DA:173,1,X1yR/f77a2wYrip3qWXYBA | ||
| DA:182,1,k9pTjjD2vJTvE7PyzhXJPw | ||
| DA:183,1,72SNpwVsw/o9etOCZ3VLaA | ||
| DA:184,1,5M8S6frycaNS3uQnlnMr2g | ||
| DA:186,1,3WsKRpW8oQhkQv0F14ak/w | ||
| DA:190,1,mUbbKvPqWHojLjV0v95bwg | ||
| DA:191,1,DdHNUt5ovAV1XQYsiT8AiQ | ||
| DA:192,1,qay3E+cJPb5xSdPWZrpBew | ||
| DA:193,1,v50IHDAPJiYZpVFrAPWUCQ | ||
| DA:194,1,siWxFuIgfjXgP30tTFf/aQ | ||
| DA:198,1,xGgKt1DFNSwI4OqNYuCmqQ | ||
| DA:199,1,XPrAAc6YApLYKhPB2ugc5w | ||
| DA:200,1,Rx8CNN7oYnLYIPSkwQ5G2w | ||
| DA:202,1,diWaG+5ccHGPOYFR5G1hZw | ||
| DA:68,0,H8roOaxT/dA+ek63CQkNsg | ||
| DA:121,0,genHDsC84NGAm0Lr+up+qQ | ||
| DA:145,0,I/UvgUIdm1YWL558qpxsAw | ||
| DA:154,0,m+4mRvWfRixXNFnr5PmwsQ | ||
| LF:72 | ||
| LH:68 | ||
| end_of_record |
There was a problem hiding this comment.
Review coverage data in lcov.info.
The coverage data indicates some modules with zero coverage. Consider adding tests for these modules to ensure functionality is correctly implemented and to prevent future regressions.
Would you like me to help in writing some of the missing tests or should I open a GitHub issue to track this task?
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/production.yml (1 hunks)
- .github/workflows/start.staging.yml (1 hunks)
- .gitignore (1 hunks)
- docker-compose.example.yml (1 hunks)
- docker-compose.test.yml (4 hunks)
Files skipped from review due to trivial changes (3)
- .github/workflows/production.yml
- .github/workflows/start.staging.yml
- .gitignore
Files skipped from review as they are similar to previous changes (1)
- docker-compose.example.yml
Additional comments not posted (2)
docker-compose.test.yml (2)
80-80: Health check configuration for PostgreSQL is properly set up.Using
pg_isreadyfor the PostgreSQL health check is a standard practice and the configuration parameters are well-tuned for quick responsiveness and reliability.
108-114: Entry point forqdrant-healthcheckservice is appropriately defined.The entry point script effectively keeps the service alive without performing any operations, which is suitable for a healthcheck container.
| depends_on: | ||
| - qdrant | ||
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://qdrant:6333/readyz"] | ||
| test: [ "CMD", "curl", "-f", "http://qdrant:6333/readyz" ] |
There was a problem hiding this comment.
Optimize the health check command for Qdrant.
The health check command for Qdrant uses curl to check the service readiness. Consider adding a retry mechanism in the curl command itself for more robust error handling.
- test: [ "CMD", "curl", "-f", "http://qdrant:6333/readyz" ]
+ test: [ "CMD", "curl", "-f", "--retry 5", "http://qdrant:6333/readyz" ]Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| test: [ "CMD", "curl", "-f", "http://qdrant:6333/readyz" ] | |
| test: [ "CMD", "curl", "-f", "--retry 5", "http://qdrant:6333/readyz" ] |
| @@ -55,7 +55,7 @@ services: | |||
| - NEO4J_PLUGINS=["apoc", "graph-data-science"] | |||
| - NEO4J_dbms_security_procedures_unrestricted=apoc.*,gds.* | |||
| healthcheck: | |||
| test: ["CMD", "wget", "http://localhost:7474"] | |||
| test: [ "CMD", "wget", "http://localhost:7474" ] | |||
There was a problem hiding this comment.
Check the health check command for Neo4j.
The health check uses wget to ensure Neo4j is running by checking the HTTP response from its web interface. This is a straightforward and effective method to verify the service is up. However, consider using --spider option with wget to avoid downloading content unnecessarily.
- test: [ "CMD", "wget", "http://localhost:7474" ]
+ test: [ "CMD", "wget", "--spider", "http://localhost:7474" ]Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| test: [ "CMD", "wget", "http://localhost:7474" ] | |
| test: [ "CMD", "wget", "--spider", "http://localhost:7474" ] |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .isort.cfg (1 hunks)
- .yamllint (1 hunks)
- server.py (1 hunks)
- worker/tasks.py (4 hunks)
- worker/worker.py (2 hunks)
Files skipped from review due to trivial changes (2)
- .isort.cfg
- .yamllint
Files skipped from review as they are similar to previous changes (3)
- server.py
- worker/tasks.py
- worker/worker.py
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
Dockerfile (1)
Line range hint
5-5: Optimize pip install command to avoid cache.Consider using
--no-cache-dirwithpip installto avoid unnecessary disk space usage that can slow down the build process.- RUN pip3 install -r requirements.txt + RUN pip3 install --no-cache-dir -r requirements.txt
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- Dockerfile (1 hunks)
- worker/celery.py (1 hunks)
- worker/tasks.py (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- worker/tasks.py
Additional context used
Hadolint
Dockerfile
[warning] 5-5: Avoid use of cache directory with pip. Use
pip install --no-cache-dir <package>(DL3042)
Additional comments not posted (2)
worker/celery.py (2)
10-14: Refactor Celery app initialization.The initialization of the Celery app has been updated to include specific task modules, which is a good practice for modular design. Ensure that the
worker.tasksmodule contains all necessary task definitions.
16-17: Ensure proper conditional execution.The addition of
if __name__ == "__main__":is a standard practice to prevent scripts from being run when they are imported as modules. This is a good addition for modular design.
| @@ -9,4 +9,4 @@ RUN chmod +x docker-entrypoint.sh | |||
| CMD ["./docker-entrypoint.sh"] | |||
|
|
|||
| FROM base AS prod | |||
| CMD ["python3", "-m", "celery", "-A", "celery_app.server", "worker", "-l", "INFO"] | |||
| CMD ["celery", "-A", "worker", "worker", "-l", "INFO"] | |||
There was a problem hiding this comment.
Update to CMD instruction needs correction.
The CMD instruction has been updated to "celery", "-A", "worker", "worker", "-l", "INFO". However, based on the summary, it seems the intention was to use "celery", "-A", "tasks", "worker", "-l", "INFO".
- CMD ["celery", "-A", "worker", "worker", "-l", "INFO"]
+ CMD ["celery", "-A", "tasks", "worker", "-l", "INFO"]Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| CMD ["celery", "-A", "worker", "worker", "-l", "INFO"] | |
| CMD ["celery", "-A", "tasks", "worker", "-l", "INFO"] |
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
worker/tasks.py (1)
Line range hint
20-121: Consider cleaning up or documenting commented-out code.The function contains large blocks of commented-out code which could potentially be confusing or misleading for other developers. If this code is meant for future use, consider adding detailed comments explaining its purpose or remove it if it's no longer needed.
Additionally, the function performs several operations which could be modularized or refactored to improve readability and maintainability. For instance, the error handling and response payload creation could be extracted into separate functions.
+ def create_error_response(interaction, question): + content = "Sorry, We cannot process your question at the moment." + response_payload = Payload.DISCORD_BOT.INTERACTION_RESPONSE.Edit( + interaction=interaction, + data=InteractionCallbackData(content=content), + ).to_dict() + return response_payload + + def send_response(event, queue, content): + job_send(event=event, queue_name=queue, content=content) + try: ... except Exception as exp: logging.error(f"Exception {exp} | during processing the question {question}") - response_payload = Payload.DISCORD_BOT.INTERACTION_RESPONSE.Edit( - interaction=chat_input_interaction, - data=InteractionCallbackData( - content="Sorry, We cannot process your question at the moment." - ), - ).to_dict() - job_send( - event=Event.DISCORD_BOT.INTERACTION_RESPONSE.EDIT, - queue_name=Queue.DISCORD_BOT, - content=response_payload, - ) + response_payload = create_error_response(chat_input_interaction, question) + send_response(Event.DISCORD_BOT.INTERACTION_RESPONSE.EDIT, Queue.DISCORD_BOT, response_payload)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- worker/celery.py (1 hunks)
- worker/tasks.py (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- worker/celery.py
Additional context used
Ruff
worker/tasks.py
6-6:
celery.signals.worker_process_initimported but unusedRemove unused import:
celery.signals.worker_process_init(F401)
worker/tasks.py
Outdated
| from celery_app.utils.fire_event import job_send | ||
| from dotenv import load_dotenv | ||
| from subquery import query_multiple_source | ||
| from celery.signals import task_postrun, worker_process_init |
There was a problem hiding this comment.
Remove unused import.
The import celery.signals.worker_process_init is unused and should be removed to keep the code clean and efficient.
- from celery.signals import task_postrun, worker_process_init
+ from celery.signals import task_postrunCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| from celery.signals import task_postrun, worker_process_init | |
| from celery.signals import task_postrun |
Tools
Ruff
6-6:
celery.signals.worker_process_initimported but unusedRemove unused import:
celery.signals.worker_process_init(F401)
There was a problem hiding this comment.
Actionable comments posted: 4
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- worker/tasks.py (5 hunks)
Additional context used
Ruff
worker/tasks.py
8-8:
celery.signals.worker_initimported but unusedRemove unused import
(F401)
9-9:
celery.signals.celeryd_initimported but unusedRemove unused import
(F401)
10-10:
celery.signals.worker_process_initimported but unusedRemove unused import
(F401)
11-11:
celery.signals.worker_readyimported but unusedRemove unused import
(F401)
12-12:
celery.signals.celeryd_after_setupimported but unusedRemove unused import
(F401)
Additional comments not posted (2)
worker/tasks.py (2)
Line range hint
29-116: Review the commented-out code.There is a significant amount of code that is commented out. If this code is no longer needed, it should be removed to keep the codebase clean. If it's temporarily disabled, consider adding a TODO or FIXME comment to clarify.
140-144: Good addition for task monitoring.Connecting the
task_prerunfunction to thetask_prerunsignal is a good practice for initializing necessary setups before task execution. This addition seems well-implemented.
worker/tasks.py
Outdated
| from celery.signals import ( | ||
| task_postrun, | ||
| worker_init, | ||
| celeryd_init, |
There was a problem hiding this comment.
Remove unused import.
The import celeryd_init is unused and should be removed to keep the code clean and efficient.
- celeryd_init,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| celeryd_init, |
Tools
Ruff
9-9:
celery.signals.celeryd_initimported but unusedRemove unused import
(F401)
worker/tasks.py
Outdated
| worker_init, | ||
| celeryd_init, | ||
| worker_process_init, | ||
| worker_ready, |
There was a problem hiding this comment.
Remove unused import.
The import worker_ready is unused and should be removed to keep the code clean and efficient.
- worker_ready,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| worker_ready, |
Tools
Ruff
11-11:
celery.signals.worker_readyimported but unusedRemove unused import
(F401)
worker/tasks.py
Outdated
| celeryd_init, | ||
| worker_process_init, | ||
| worker_ready, | ||
| celeryd_after_setup, |
There was a problem hiding this comment.
Remove unused import.
The import celeryd_after_setup is unused and should be removed to keep the code clean and efficient.
- celeryd_after_setup,Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| celeryd_after_setup, |
Tools
Ruff
12-12:
celery.signals.celeryd_after_setupimported but unusedRemove unused import
(F401)
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- worker/tasks.py (5 hunks)
Additional context used
Ruff
worker/tasks.py
8-8:
celery.signals.worker_initimported but unusedRemove unused import
(F401)
9-9:
celery.signals.celeryd_initimported but unusedRemove unused import
(F401)
10-10:
celery.signals.worker_process_initimported but unusedRemove unused import
(F401)
12-12:
celery.signals.celeryd_after_setupimported but unusedRemove unused import
(F401)
13-13:
celery.signals.task_prerunimported but unusedRemove unused import
(F401)
Additional comments not posted (3)
worker/tasks.py (3)
25-29: Update import paths and initialization of tracing.The imports have been updated to reflect the new module structure, and
init_tracingis introduced for tracing functionalities. Ensure that these changes are correctly integrated and tested across the application.
177-180: Garbage collection triggered after each task.The
task_postrunsignal handler now includes a call togc.collect(), which triggers garbage collection after each task. This can help manage memory more efficiently in environments with frequent task executions.
161-166: Utilizeworker_readysignal for tracing initialization.The
worker_readysignal is now connected to a handler that initializes tracing. Verify that this change integrates well with the rest of the application's lifecycle and does not introduce any unintended side effects.
worker/tasks.py
Outdated
| from subquery import query_multiple_source | ||
| from celery.signals import ( | ||
| task_postrun, | ||
| worker_init, |
There was a problem hiding this comment.
Remove unused imports to clean up the code.
Several signal imports are declared but not used, which can lead to unnecessary clutter in the codebase.
- from celery.signals import (
- worker_init,
- celeryd_init,
- worker_process_init,
- celeryd_after_setup,
- task_prerun,
- )
+ from celery.signals import (
+ task_postrun,
+ worker_ready,
+ )Also applies to: 9-9, 10-10, 12-12, 13-13
Tools
Ruff
8-8:
celery.signals.worker_initimported but unusedRemove unused import
(F401)
.isort.cfg
Outdated
| @@ -0,0 +1,2 @@ | |||
| [settings] | |||
| check = false | |||
There was a problem hiding this comment.
did we disable isort linter?
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- worker/celery.py (2 hunks)
- worker/tasks.py (5 hunks)
Files skipped from review as they are similar to previous changes (2)
- worker/celery.py
- worker/tasks.py
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- server.py (2 hunks)
- utils/traceloop.py (1 hunks)
- worker/celery.py (1 hunks)
- worker/tasks.py (5 hunks)
Files skipped from review as they are similar to previous changes (4)
- server.py
- utils/traceloop.py
- worker/celery.py
- worker/tasks.py
Summary by CodeRabbit
docker-compose.example.ymlcommands forwebservice and removed command configuration forworkerservice.server.pyfor better organization.worker/worker.pyandworker/celery.py.worker/tasks.pywith new tracing initialization and updated imports..gitignoreentry forcoverage/.docker-compose.test.yml..isort.cfg..yamllint.init_tracing()function inutils/traceloop.pyfor environment-based tracing initialization.