Fix/metadata filtering #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We can now fetch similar nodes by manually doing metadata filterings on database!
- Because the PGVectorStore didn't support combination of `AND` and `OR` conditions we needed to do it manually and now other parts had to change too! - Still I haven't didn't test the whole process in subquery generator.
TjitsevdM
reviewed
Feb 1, 2024
| query_engine = self.engine.prepare_platform_engine( | ||
| # the output should always have a `date` key for each dictionary | ||
| filters = [ | ||
| {"channel": "general", "date": "2023-01-02"}, |
There was a problem hiding this comment.
Do we have test cases where multiple channels/threads/dates are provided?
There was a problem hiding this comment.
This file contains test cases for applying multiple OR between each item of the filters list and two or one AND operation between each item of the list (each dictionaries). Adding a thread to it, is no different as it would add three AND operator instead of two for date and channel.
TjitsevdM
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.