Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code climate fix #38

Merged
merged 4 commits into from
Jun 7, 2024
+6 −1
Merged

code climate fix #38

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc3dfef
code climate fix
cyri113 Jun 7, 2024
e4393c4
lcov
cyri113 Jun 7, 2024
3e2c56d
debug false
cyri113 Jun 7, 2024
f6467f1
yarn coverage
cyri113 Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- run: yarn install
- run: yarn coverage
- uses: paambaati/[email protected]
env:
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
with:
coverageCommand: npm run coverage
debug: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Inconsistent usage of npm and yarn in the CI workflow file.

  • .github/workflows/ci.yml: Lines where yarn is used:
    • - run: yarn install
    • - run: yarn compile

To ensure consistency and avoid potential issues with dependency management, update all yarn commands to npm.

Analysis chain

Switch from yarn to npm for coverage command and enabling debug mode.

Ensure that the switch to npm from yarn is consistent across all workflow files to avoid conflicts or issues with dependency management. Additionally, consider the implications of enabling debug mode in a production CI pipeline, as it might expose sensitive information or increase log verbosity unnecessarily.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify consistency in the use of npm over yarn throughout the project.

# Test: Search for npm and yarn usage in the project. Expect: Consistent usage of one package manager.
rg --type yaml 'npm run' .github/workflows/
rg --type yaml 'yarn' .github/workflows/

Length of output: 534


# deploy:
# runs-on: ubuntu-latest
Expand Down
Loading