close #34

TogetherCrew · Jun 7, 2024 · 28309f2 · 28309f2
1 parent 9205f2a
commit 28309f2
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/contracts/Engagement.sol b/contracts/Engagement.sol
@@ -66,7 +66,10 @@ contract EngagementContract is IEngagement, ERC1155, AccessControl {
         string memory account
     ) external view override returns (string memory) {}
 
-    function updateScores(uint date, string memory cid) external override {}
+    function updateScores(
+        uint date,
+        string memory cid
+    ) external override onlyRole(PROVIDER_ROLE) {}
 
     function supportsInterface(
         bytes4 interfaceId

diff --git a/test/engagements.ts b/test/engagements.ts
@@ -309,5 +309,25 @@ describe("Engage", function () {
         });
       });
     });
+    describe("Update Scores", function () {
+      const date = BigInt(1625097600);
+      const cid = "SOME_RANDOM_CID";
+      describe("Revert", async function () {
+        it("Should revert with AccessControlUnauthorizedAccount (msg.sender doesn't have PROVIDER_ROLE)", async function () {
+          const { contract, otherAccount } = await loadFixture(deployFixture);
+          const PROVIDER_ROLE = await contract.read.PROVIDER_ROLE();
+
+          await expect(
+            contract.write.updateScores([date, cid], {
+              account: otherAccount.account.address,
+            })
+          ).to.be.rejectedWith(
+            `AccessControlUnauthorizedAccount("${getAddress(
+              otherAccount.account.address
+            )}", "${PROVIDER_ROLE}")`
+          );
+        });
+      });
+    });
   });
 });