-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add question message to bot response #240
Conversation
WalkthroughThe changes in this pull request focus on modifying the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
hivemind-adapter/src/hivemind-adapter/hivemind.adapter.service.ts (2)
47-47
: LGTM! Consider adding null/empty message handling.The formatting change improves readability by clearly distinguishing the question from the response using markdown and proper spacing.
Consider adding null checks for message properties to handle edge cases:
- content: `**${question.question.message}**\n${question.response.message}`, + content: `**${question.question.message || 'No question provided'}**\n${question.response.message || 'No response available'}`,
46-48
: Consider extracting message formatting to a constant or configuration.To maintain consistency across the application and make future formatting changes easier, consider extracting the message template to a constant or configuration.
Example implementation:
// Add to top of file with other constants const MESSAGE_TEMPLATES = { QUESTION_RESPONSE: (question: string, response: string) => `**${question}**\n${response}` } as const; // Then in the method content: MESSAGE_TEMPLATES.QUESTION_RESPONSE( question.question.message, question.response.message ),
Summary by CodeRabbit