-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exclude embedding and llm metadata! #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Excluding all metadata for embedding model. - Including `date`, `channel`, `author_username`, `channel` and `thread` for LLM. - Adding a dot at the end of discord message content, as it would prevent the node not having any data when the message was empty.
The test cases were related to previous PRs of adding `fromDate` to modules collection.
if from_date was equal to `None`, it would use the modules fromDate which in our case the modules date wasn't configured correctly!
- The url extractor is now more consistent as we changed to use a library. - Checking the messages for any alphabetical content after urls removed.
In case of globalName and nickname being very different from username the LLM wouldn't be able to answer, so we included these two information.
…de-embed-llm-data Merge branch 'update/backend-dependency-lib' into feat/hivemind-exclude-embed-llm-data That branch was fixing some test cases which we forgot to fix before.
- We've included the `None` value for test cases so we the LLM wouldn't be confused if the message was sent in channel.
This was
linked to
issues
Jan 25, 2024
TjitsevdM
approved these changes
Jan 25, 2024
cyri113
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date
,channel
,author_username
,channel
andthread
for LLM.