-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: telegram vectorize, added field schema option for getting the latest document! #308
Conversation
WalkthroughThe changes involve modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
dags/hivemind_etl_helpers/ingestion_pipeline.py (1)
136-139
: Enhance the docstring forfield_schema
.The docstring update for the new
field_schema
parameter is good, but it could be more specific about its usage and potential values.Consider updating the docstring as follows:
field_schema : qdrant_client.conversions.common_types.PayloadSchemaType The schema type of the date field in Qdrant. Use PayloadSchemaType.DATETIME for native datetime fields, or PayloadSchemaType.FLOAT for timestamp fields. Defaults to PayloadSchemaType.DATETIME.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- dags/hivemind_etl_helpers/ingestion_pipeline.py (3 hunks)
🧰 Additional context used
🔇 Additional comments (2)
dags/hivemind_etl_helpers/ingestion_pipeline.py (2)
150-151
: LGTM: Proper usage of the newfield_schema
parameter.The
_create_payload_index
method call has been correctly updated to include thefield_schema
parameter. This change ensures that the index is created with the appropriate schema type as specified by the caller.
Line range hint
122-151
: Overall improvement in flexibility and consistency.The changes to the
get_latest_document_date
method enhance its flexibility by allowing different field schema types. The implementation maintains consistency with the existing error handling and logging mechanisms. The added parameter and its usage in the_create_payload_index
method call are well-integrated.Consider the suggestions above to further improve the default value and documentation. These changes will make the method more intuitive and easier to use correctly.
Summary by CodeRabbit