Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/discord-forum retriever #27
Feat/discord-forum retriever #27
Changes from 6 commits
fbca09a
dfbc966
37700d4
76be4ea
16ebee9
1ec940b
c3e5d89
eb126e8
fe8082b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the top_k for the summaries or or the raw messages? Ideally, we have a separate parameter for each (k1 and k2 in card description under low level design). Also, is there a place where the d parameter is passed to a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking, The
similarity_top_k
in for thequery_discord_auto_filter
is the k2, I'll see how the k1 can be adjusted in the secondary search (which would be in the functionquery_discord
.For the parameter
d
I was thinking to just include all the givendate
from metadata and not the time interval, which I'll fix and add based on the card.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two missing (
d
andk1
) parameters added and can be read from the.env
file. Please let me know if you had any more questions.