Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Issue 434 fixed discord and github login link clickable #438

Conversation

neeravbhaskarla
Copy link
Contributor

Description

Resolved the issue pertaining to the Discord Login functionality and rectified the GitHub link on the landing page, which was visually resembling a button, but only the text and logo areas were clickable. The resolution entailed relocating the relevant styles within the button or link () element, resulting in full clickability across the entire element.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires an update to testing

Issue

Checklist:

  • This PR is up to date with the main branch, and merge conflicts have been resolved
  • I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
  • I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@neeravbhaskarla neeravbhaskarla changed the title Bugfix/issue loginandgithublinkfix 434 Bug/Issue 434 fixed discord and github login link clickable Jul 21, 2023
@neeravbhaskarla neeravbhaskarla temporarily deployed to DEV July 25, 2023 18:46 — with GitHub Actions Inactive
@Caleb-Cohen Caleb-Cohen merged commit 2a7289e into Together-100Devs:main Jul 25, 2023
1 check passed
@Caleb-Cohen
Copy link
Member

Great work!

@neeravbhaskarla neeravbhaskarla deleted the bugfix/issue-loginandgithublinkfix-434 branch July 26, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants