-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support several multipliers for a QSO #442
Conversation
@@ -39,6 +39,49 @@ | |||
|
|||
GPtrArray *mults_possible; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe locate function near related remember_multi()?
} else if (generic_mult != MULT_NONE) { | ||
|
||
strncat(logline, qso->mult1_value, 9); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if we have >=10 points? We get no space between multi and points.
Or should we drop one more character from the combined multi field ... That would allow only 7 characters. I fear we must live with the missing separating space here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have to live with the missing separator. A wider terminal screen could solve this, but also introduce a bunch of other problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing that one before.
The solution will certainly work for now. Would be nice if the single mults were vertically aligned, but that looks difficult in the actual case.
In the long run a solution with a separate handling of the different multipliers would be desirable. (Same goes for the separate scoring of multipliers per txmode.)
Otherwise LGTM.
Btw, we can give us some more room for multipliers if we change the 'displayed' date from 12-Aug-24 to 12Aug24. Similar, but not as readable would be to drop the ':' from 17:09. In summary that are 2..3 characters more for the information on the right side. The displayed line would than read as
Be aware that I am NOT talking about changing the line format in log file, but only on display. Downside: We need separate functions to format both (But that may not be a bad decision.). |
Yes, the on-screen format could be tuned. We still have to store something in the log file, so there it will be truncated. As this is quite a special case, I'd postpone any changes for later. |
Allow generating several multipliers for a single QSO. These are generated by the corresponding contest plugin as a space separated list. Usages include both explicit multipliers as for California QSO party and also derived ones as for EU-DX. In the latter case both DXCC and the EU region code count as multipliers.
Added rules for EU-DX.
Resolves #411.