Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support several multipliers for a QSO #442

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

zcsahok
Copy link
Member

@zcsahok zcsahok commented Oct 1, 2024

Allow generating several multipliers for a single QSO. These are generated by the corresponding contest plugin as a space separated list. Usages include both explicit multipliers as for California QSO party and also derived ones as for EU-DX. In the latter case both DXCC and the EU region code count as multipliers.

Added rules for EU-DX.

Resolves #411.

@zcsahok zcsahok requested a review from dl1jbe October 20, 2024 21:10
@@ -39,6 +39,49 @@

GPtrArray *mults_possible;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe locate function near related remember_multi()?

} else if (generic_mult != MULT_NONE) {

strncat(logline, qso->mult1_value, 9);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we have >=10 points? We get no space between multi and points.

Or should we drop one more character from the combined multi field ... That would allow only 7 characters. I fear we must live with the missing separating space here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have to live with the missing separator. A wider terminal screen could solve this, but also introduce a bunch of other problems.

Copy link
Member

@dl1jbe dl1jbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing that one before.

The solution will certainly work for now. Would be nice if the single mults were vertically aligned, but that looks difficult in the actual case.

In the long run a solution with a separate handling of the different multipliers would be desirable. (Same goes for the separate scoring of multipliers per txmode.)

Otherwise LGTM.

@dl1jbe
Copy link
Member

dl1jbe commented Oct 23, 2024

Btw, we can give us some more room for multipliers if we change the 'displayed' date from 12-Aug-24 to 12Aug24.

Similar, but not as readable would be to drop the ':' from 17:09. In summary that are 2..3 characters more for the information on the right side.

The displayed line would than read as

40CW 20Feb22 1709 0004 VE3KL 599 599 23 VE3 1

Be aware that I am NOT talking about changing the line format in log file, but only on display. Downside: We need separate functions to format both (But that may not be a bad decision.).

@zcsahok
Copy link
Member Author

zcsahok commented Oct 24, 2024

Yes, the on-screen format could be tuned. We still have to store something in the log file, so there it will be truncated. As this is quite a special case, I'd postpone any changes for later.

@zcsahok zcsahok merged commit 0595992 into Tlf:master Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submitting contact with several multipliers
2 participants