[FE] Typography component #78
Conversation
| className?: string; | ||
| } | ||
|
|
||
| export type TypographyVariants = |
There was a problem hiding this comment.
I was considering splitting variant and font weight to different parameters, but I decided to leave it this way to stay consistent with typography styles from Figma (I only shortened 'Heading' to 'head'). I think it would be easier to use while implementing new views:
For example:
Jane Edge has a style named "Headline M/Meddium", so for the Typography component we should use the head-m/medium variant
There was a problem hiding this comment.
I agree, I've split button styles into two separate props to reflect Figma. Your approach makes sense to me 👌
There was a problem hiding this comment.
Good ideas, let's go with that
| className?: string; | ||
| } | ||
|
|
||
| export type TypographyVariants = |
There was a problem hiding this comment.
I agree, I've split button styles into two separate props to reflect Figma. Your approach makes sense to me 👌
| {small ? ( | ||
| <Typography variant="body-m/semibold">{title}</Typography> | ||
| ) : ( | ||
| <Typography variant="head-s/semibold">{title}</Typography> | ||
| )} |
There was a problem hiding this comment.
maybe something like that:
| {small ? ( | |
| <Typography variant="body-m/semibold">{title}</Typography> | |
| ) : ( | |
| <Typography variant="head-s/semibold">{title}</Typography> | |
| )} | |
| <Typography variant={small ? "body-m/semibold" : "head-s/semibold"}>{title}</Typography> |
No description provided.