[FE][CPF-36] Add listbox and basic people logic refactor #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1skz3ro
force-pushed
the
feat/cpf-36-people-page-improvements
branch
from
6e3ffad
to
125034c
Compare
skorekm
reviewed
Jul 19, 2024
| {!value && placeholder ? placeholder : value?.name} | ||
| {selected ? ( | ||
| <div | ||
| onClick={(e) => { |
There was a problem hiding this comment.
Let's avoid adding logic in jsx
skorekm
reviewed
Jul 19, 2024
| onChange={(e) => onTabChange(e.target.value)} | ||
| defaultValue={tabs.find((tab) => tab.key === currentTab)?.label} | ||
| onChange={(e) => { | ||
| const tab = tabs.find((tab) => tab.name === e.target.value); |
There was a problem hiding this comment.
How about extracting it to the function?
skorekm
reviewed
Jul 19, 2024
wiktoriasalamon
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.