code-style

TitasGailius · Nov 24, 2020 · 9adcce0 · 9adcce0
1 parent 6bc03e3
commit 9adcce0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 20 deletions.
diff --git a/src/Fakes/BuilderFake.php b/src/Fakes/BuilderFake.php
@@ -132,6 +132,6 @@ public static function assertExecuted($command, int $times = 1)
      */
     public static function assertNotExecuted($command)
     {
-        self::assertExecuted($command, 0);
+        static::assertExecuted($command, 0);
     }
 }
diff --git a/tests/FakeTerminalTest.php b/tests/FakeTerminalTest.php
@@ -50,19 +50,14 @@ public function testAssertNotExecuted()
     {
         Terminal::fake();
 
-        Terminal::assertNotExecuted($expected = 'echo "Hello, World"');
+        Terminal::assertNotExecuted($command = 'echo "Hello, World"');
 
-        Terminal::execute($expected);
+        Terminal::execute($command);
 
         $this->expectException(ExpectationFailedException::class);
-        Terminal::assertNotExecuted($expected = 'echo "Hello, World"');
+        Terminal::assertNotExecuted($command = 'echo "Hello, World"');
     }
 
-    /**
-     * Test that Terminal can capture and assert executions using a custom filter.
-     *
-     * @return void
-     */
     public function testCaptureAndAssertExecutedUsingCustomFilter()
     {
         Terminal::fake();
@@ -74,26 +69,22 @@ public function testCaptureAndAssertExecutedUsingCustomFilter()
         });
     }
 
-    /**
-     * Test that Terminal can assert that a given command was not executed using a custom filter.
-     *
-     * @return void
-     */
     public function testAssertNotExecutedUsingCustomFilter()
     {
         Terminal::fake();
 
-        $expected = 'echo "Hello, World"';
+        $command = 'echo "Hello, World"';
 
-        Terminal::assertNotExecuted(function ($captured) use ($expected) {
-            return $captured->toString() == $expected;
+        Terminal::assertNotExecuted(function ($captured) use ($command) {
+            return $captured->toString() == $command;
         });
 
-        Terminal::execute($expected);
+        Terminal::execute($command);
 
         $this->expectException(ExpectationFailedException::class);
-        Terminal::assertNotExecuted(function ($captured) use ($expected) {
-            return $captured->toString() == $expected;
+
+        Terminal::assertNotExecuted(function ($captured) use ($command) {
+            return $captured->toString() == $command;
         });
     }