Skip to content

Commit

Permalink
🐛 Fix test_dsl for pytest>=8.3.0 (#845)
Browse files Browse the repository at this point in the history
- The new version of `pytest` (>=8.3.0) does not update variables properly in different scenarios. This causes the tests to fail. As a fix I have nested variables in a dictionary and then parse them for each function.
- Remove pin from `pytest` version.
  • Loading branch information
shaneahmed authored Aug 15, 2024
1 parent a6fceef commit af5f284
Show file tree
Hide file tree
Showing 3 changed files with 96 additions and 116 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
sudo apt update
sudo apt-get install -y libopenslide-dev openslide-tools libopenjp2-7 libopenjp2-tools
python -m pip install --upgrade pip
python -m pip install ruff==0.5.7 "pytest<8.3.0" pytest-cov pytest-runner
python -m pip install ruff==0.5.7 pytest pytest-cov pytest-runner
pip install -r requirements/requirements.txt
- name: Cache tiatoolbox static assets
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion requirements/requirements_dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mypy>=1.6.1
pip>=22.3
poetry-bumpversion>=0.3.1
pre-commit>=2.20.0
pytest>=7.2.0, <8.3.0
pytest>=7.2.0
pytest-cov>=4.0.0
pytest-runner>=6.0
pytest-xdist[psutil]
Expand Down
Loading

0 comments on commit af5f284

Please sign in to comment.