forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ECO][Inventory v2] Remove the landing page to enable the entity model (
elastic#205534) Closes elastic#203095 Closes elastic#204263 ## Summary This PR removes the page for the enabling functionality and welcome screen. After the migration to v2 API we don't need to enable it anymore as we are not using transforms ### Before: ![image](https://github.com/user-attachments/assets/0c8d5841-9189-4551-a1be-87801cfcf57d) ![image](https://github.com/user-attachments/assets/75a73dd8-6b16-452b-abcf-41e1fcca6645) ### After: The same without the extra step to enable the entities and the welcome screen: - No data: ![image](https://github.com/user-attachments/assets/dbfdf501-36e7-4b6f-a8b6-ed0a6748ab62) - With data: ![image](https://github.com/user-attachments/assets/0bbb2983-4e0a-477c-ac11-d2256b5ff854) ## Testing - In a local environment enable the entities feature flag ( it should be a clean env as the entities should not be enabled before ): <img width="1911" alt="image" src="https://github.com/user-attachments/assets/75d6f77d-5039-41ca-80ca-34c3bf99844e" /> - Go to Inventory - Check before and after ingesting data - Synthtrace: `node scripts/synthtrace logs_traces_hosts.ts` - ~⚠️ this case can't be checked before elastic#203452 is merged~ - elastic#203452 is merged 🎉
- Loading branch information
1 parent
15a1611
commit d6e28f7
Showing
11 changed files
with
5 additions
and
476 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-176 KB
...tions/observability/plugins/inventory/public/assets/entities_inventory_dark.png
Binary file not shown.
Binary file removed
BIN
-176 KB
...ions/observability/plugins/inventory/public/assets/entities_inventory_light.png
Binary file not shown.
71 changes: 0 additions & 71 deletions
71
...lity/plugins/inventory/public/components/entity_enablement/enable_entity_model_button.tsx
This file was deleted.
Oops, something went wrong.
100 changes: 0 additions & 100 deletions
100
...bservability/plugins/inventory/public/components/entity_enablement/unauthorized_modal.tsx
This file was deleted.
Oops, something went wrong.
100 changes: 0 additions & 100 deletions
100
...ons/observability/plugins/inventory/public/components/entity_enablement/welcome_modal.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.