add DigitalOcean provider #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, later I'll update the web panel to support this new provider. |
|
It seems the lint job shows 2 errors, would u pls help to fix them? |
Oh, I didn't see any references to specific providers in the web/ directory so I assumed it would work out of the box. Anything I can do to help? Linting errors are ✔️ |
|
For the web panel, I think the only thing that should be updated is at: https://github.com/TimothyYe/godns/blob/master/internal/utils/constants.go#L98-L101 I see you've already added this new provider setting, it looks good! |
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for domains managed by DigitalOcean.
I'm not a particularly experienced Go author but I used the CloudFlare provider as a template so I'm hoping I didn't violate any conventions. I've tested that creating, updating and skipping of domains works for subdomains and root domains (using
"@"as a subdomain).