Use undefined instead of null as default value

This fixes the type issues in mapbox#107. Also it makes more sense. I'm unsure about the `return undefined`.
Timmmm · Nov 6, 2019 · 7b723c1 · 7b723c1
1 parent b4eab64
commit 7b723c1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/compile.js b/compile.js
@@ -101,7 +101,7 @@ function compileDest(ctx) {
     for (var i = 0; i < ctx._proto.fields.length; i++) {
         var field = ctx._proto.fields[i];
         props[field.name + ': ' + JSON.stringify(ctx._defaults[field.name])] = true;
-        if (field.oneof) props[field.oneof + ': null'] = true;
+        if (field.oneof) props[field.oneof + ': undefined'] = true;
     }
     return '{' + Object.keys(props).join(', ') + '}';
 }
@@ -295,7 +295,7 @@ function getDefaultValue(field, value) {
     case 'string':   return value || '';
     case 'bool':     return value === 'true';
     case 'map':      return {};
-    default:         return null;
+    default:         return undefined;
     }
 }