Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faculty of Physics, St. Petersburg State University #79

Merged
merged 14 commits into from
Dec 7, 2023
Merged

Conversation

TimPushkin
Copy link
Owner

  • Adds a map of the Faculty of Physics, St. Petersburg State University
  • Changes map tile assets format to be more space-efficient: PNG is replaced with WebP, fully transparent tiles are omitted
  • is_closed marker status is removed since it can change more frequently than the maps get updated
  • Closes Update marker texts when language changes #2 (see onLocaleChange() added to view models in 8e8e333)

@TimPushkin TimPushkin marked this pull request as ready for review December 7, 2023 19:22
@TimPushkin
Copy link
Owner Author

Will ignore the "The function MapScreen is too long" warning from Codacy because I have no idea how to meaningfully shrink this function any further at the moment

@TimPushkin TimPushkin merged commit f8cd508 into main Dec 7, 2023
2 of 3 checks passed
@HolySSSS
Copy link

HolySSSS commented May 15, 2024

I'm trying to implement a third map for the purposes getting used to understanding someone's code by myself, but this so far stumped me.

I added a new map into the same Database, a new tile pyramid into the app and it leads to the app crashing in Android Studio.
So, there are 3 maps, 3 tile sets now in the DepNav, nothing else.
I did not do any other actions to the Database or the tile sets after creating them and putting them into the app.

изображение
изображение

I also did not add any new UI elements to represent the third map at the moment of writing this, for I am currently trying to understand how to implement one in your code.
The third map is called "Third" or "Третий" currently.
Thanks for any help.

@TimPushkin TimPushkin deleted the spbu-pf branch May 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update marker texts when language changes
2 participants