Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the MantisThemeManager to support Mantis BT 2.x #5

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Samunosuke
Copy link

The MantisThemeManager was/is a good approach to change the style of the mantis installation without modifying the source code of the Mantis BT. So I still think it can be useful especially when we think about how long it did take that the writers of mantis have brought a fresh look, which still lacks of a lot of potential.

- added addStyleScript (event handler) function to add custom java script code to the site -> this will allow to perform any required changes to DOM (the new Mantis BT themes are much more complex than previous ones from 1.2x or 1.3x) 
- changed version to 0.0.2
- changed Mantis Core requirement to 2.0
@SugarD-x
Copy link

SugarD-x commented Dec 8, 2017

Is this working on the latest version of MantisBT?

@Samunosuke
Copy link
Author

I made a proof of concept and it works so far - but it lacks of templates. https://github.com/Samunosuke/mantis-suke-theme
I started with the first intention to just modify the css, but the writer of Mantis did often use "!important" which did prevent from simply load another css. So it is required to manipulate the DOM, e.g. via JQuery to allow templating.

@SugarD-x
Copy link

SugarD-x commented Dec 8, 2017

Sweet!

Do your changes to the MantisBT Theme Manager have any issues so far in the latest version of MantisBT, though? I'm considering upgrading my bug tracker and applying your fixes to the Theme Manager plugin to get my stuff back online. (I'm also watching your theme now too!)

@Samunosuke
Copy link
Author

Samunosuke commented Dec 8, 2017

I could not see any issues, my changes are just focused on the visual aspects and the good thing I did not had to do any changes to Mantis. It is just a plugin which changes the style by modifying the DOM during loading of the page. The "Rockstar" Theme from Tim does not work any more because it would need a lot of changes to get it working with new Mantis 2.x versions. So I started with a minimalistic approach.

@SugarD-x
Copy link

Ah, roger. Thank you!

Too bad his theme no longer works. I was using a heavily modified version of it for my website alongside several HTML-based changes to the core files. (This should be fun updating it, sarcasm!)

I appreciate the information. Looks like I'll be using your theme this time around then!

@SugarD-x
Copy link

Just thought I'd slap in an update. I'm still fixing bugs, but I've managed to integrate my code into your theme on my Mantis installation in the latest version, and I'm liking how it turned out! Your theme manager is godly!

predivivus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants