Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to golang modules, add some new features #8

Merged
merged 4 commits into from
Jun 21, 2019
Merged

Migrate to golang modules, add some new features #8

merged 4 commits into from
Jun 21, 2019

Conversation

nlamirault
Copy link
Contributor

@nlamirault nlamirault commented May 28, 2019 •
edited
Loading

  • Use golang modules for dependencies
  • Implements Update which could now rename a channel
  • datasource for users (See Add user management #4 )

nlamirault added 4 commits May 28, 2019 17:02
@nlamirault
Add: golang modules
0d41f8f 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Add: scripts from others Terraform providers
5fb78ca 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Add: update channel feature
cf66b7f 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
Add: datasource for user and channel members
753db07 
Signed-off-by: Nicolas Lamirault <[email protected]>
@TimDurward TimDurward self-requested a review June 21, 2019 02:52
TimDurward
TimDurward approved these changes Jun 21, 2019
View reviewed changes
Copy link
Owner

@TimDurward TimDurward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm for adding go modules, it was something I've been meaning to do for versioning.

Tested, looks good, passes my review 👍

@TimDurward TimDurward merged commit 904b9a1 into TimDurward:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimDurward TimDurward TimDurward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlamirault @TimDurward