Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the libmagic vcpkg port overlay to version 5.45. (#5332) #5418

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

ihnorton
Copy link
Member

@ihnorton ihnorton commented Jan 7, 2025

Backport #5332 to release-2.26 to fix conda-forge/tiledb-feedstock#399


SC-56749

This PR updates our custom vcpkg port overlay for libmagic to version 5.45. Unlike the last time we attempted this (#4673), this PR does not replace the port with the upstream autotools-based one, and is not expected to be a build-breaking change.


TYPE: IMPROVEMENT
DESC: Updated libmagic to version 5.45.

(cherry picked from commit c44fb49)


TYPE: NO_HISTORY | FEATURE | BUG | IMPROVEMENT | DEPRECATION | C_API | CPP_API | BREAKING_BEHAVIOR | BREAKING_API | FORMAT
DESC:

[SC-56749](https://app.shortcut.com/tiledb-inc/story/56749/update-the-libmagic-vcpkg-port-overlay-to-version-5-45)

This PR updates our custom vcpkg port overlay for libmagic to version
5.45. Unlike the last time we attempted this (#4673), this PR does not
replace the port with the upstream autotools-based one, and is not
expected to be a build-breaking change.

---
TYPE: IMPROVEMENT
DESC: Updated libmagic to version 5.45.

(cherry picked from commit c44fb49)
@jdblischak
Copy link
Contributor

I tested this PR branch in my fork of tiledb-feedstock to confirm it fixes the libmagic configuration error for tiledb 2.26.

  • Using this PR branch, the CI passes (commit, build)

  • Reverting to the current 2.26.2, the CI continues to fail (commit, build)

@ihnorton ihnorton marked this pull request as ready for review January 7, 2025 20:44
@ihnorton ihnorton merged commit 69ef84e into release-2.26 Jan 7, 2025
57 of 62 checks passed
@ihnorton ihnorton deleted the ihn/cherry-pick-5332 branch January 7, 2025 22:07
@jdblischak jdblischak mentioned this pull request Jan 7, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants