Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce aarch64 release artifacts from manylinux2014 container #5348

Merged
merged 36 commits into from
Nov 14, 2024
Merged

Produce aarch64 release artifacts from manylinux2014 container #5348

merged 36 commits into from
Nov 14, 2024

Conversation

dudoslav
Copy link
Collaborator

@dudoslav dudoslav commented Oct 14, 2024 •
edited
Loading

This PR changes the way the aarch64 artifacts are produced. We no longer cross compile, but instead use private aarch64 runner.To test the CI we use custom repo fork.

TYPE: IMPROVEMENT
DESC: aarch64 release artifacts (manylinux2014 environment)

@dudoslav dudoslav self-assigned this Oct 14, 2024
@dudoslav
Do not use sudo
52f8fd4
@dudoslav
Install aarch64 deps using yum
208cc05
@dudoslav
Install glibc
1cec4bc
@dudoslav
Use newer version of manylinux container
b551e05
@dudoslav
Use manylinux-cross
0bc21be
@dudoslav
Install dependencies from apt
d200f92
@dudoslav
Apt update
95f3dee
@dudoslav
Use x86_64 toolchain image
ce5e617
@dudoslav
Try out aarch64-amd64 manylinux
01eee2b
@dudoslav
Do not source error log print
3619bc1
@dudoslav
Use sh instead of source
6df111e
@dudoslav
TEMP: Change default compiler values
bca7be5
@dudoslav
TEMP: Set hardcoded compiler
6c750b7
@dudoslav
Use native arm64 runner
2af917f
@dudoslav
Fix runs-on
632a1da
@dudoslav
Modify release CI to run in PR
022783e
@dudoslav
Install ninja-build on linux
d105286
@dudoslav
Install ninja using pip
61634e3
@dudoslav
Add env variable for arm64 specific build
124971a
@dudoslav
Remove env
ae0c420
@dudoslav
properly set VCPKG_FORCE_SYSTEM_BINARIES
02808e6
@dudoslav
Fix ternary operator
378a7fb
@dudoslav
Fix
1fca2bc
@dudoslav
Use bash in print on error for Windows
ed56602
@dudoslav
Merge remote-tracking branch 'origin/dev' into db/aarch64_manylinux
af9cb9a
@dudoslav
Brew install ninja
972010b
@dudoslav
Set path only for linux builds
de7935d
@dudoslav
Rename C and CXX compiler for aarch64
342d87e
@dudoslav dudoslav changed the title Draft: Cross compile aarch64 inside manylinux container Cross compile aarch64 inside manylinux container Oct 29, 2024
@dudoslav dudoslav changed the title Cross compile aarch64 inside manylinux container Produce aarch64 release artifacts from manylinux2014 container Oct 29, 2024
teo-tsirpanis
teo-tsirpanis approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Validated by uploading the binaries to a custom NuGet feed, and successfully running a small C# program that calls tiledb_version on an ARM64 EC2 instance.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@ihnorton ihnorton merged commit 67d9028 into TileDB-Inc:dev Nov 14, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teo-tsirpanis teo-tsirpanis teo-tsirpanis approved these changes

@ihnorton ihnorton Awaiting requested review from ihnorton

Assignees

@dudoslav dudoslav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudoslav @teo-tsirpanis @ihnorton