Do not pass back RTrees to clients unless it's needed #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbindar
force-pushed
the
rbin/ch53761/move_loadedmeta_query
branch
2 times, most recently
from
207bde0
to
4c42aa2
Compare
robertbindar
force-pushed
the
rbin/ch53761/move_loadedmeta_query
branch
from
147525a
to
3b25115
Compare
robertbindar
changed the title
robertbindar
changed the title
|
When you say: "I validated this change against a local REST server and arrays can be read with no issues by older clients.", you mean with older python clients? |
Older python client with and without array open and query v3 enabled. |
ypatia
approved these changes
Sep 4, 2024
ypatia
added a commit
that referenced
this pull request
Nov 15, 2024
This reverts #5265 although it has introduced a good change: only serialize rtrees when absolutely needed. However, the problem is that the server will be in 2.26 and will expect to serialize rtrees that have not been deserialized before and will fail. This will not allow the release to get verified completely. --- TYPE: IMPROVEMENT DESC: Revert selective Rtree serialization to allow release testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details here: https://app.shortcut.com/tiledb-inc/story/54168/figure-out-correct-serialization-of-rtrees-in-rest
RTrees are only needed in global order writes, unordered partial attribute writes and FragmentInfo APIs.
I validated this change against a local REST server and arrays can be read with no issues by older clients.
TYPE: IMPROVEMENT
DESC: Do not pass back RTrees to clients.