[cpp_api] Update Deleter to not free null pointers.
#5262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-53365
This PR updates the
Deleterclass do nothing when a null pointer is passed to it. Previously it would pass the pointer totiledb_***_free, which would cause an error that gets ignored because most APIs returnvoid, and emit an error log message. This resulted in lots of noise in CI logs.There are some cases in the C++ API where a null handle would be attempted to be freed, like here or here. Some of them can be eliminated by refactoring the initialization of the smart pointers, but this change is nevertheless valuable, because not all cases can be migrated, and null smart pointers are valid either way.
TYPE: CPP_API
DESC: Fix error log messages when using the
Arrayclass in the C++ API.