Use unordered layout for aggregate-only read queries on sparse arrays. #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
force-pushed
the
teo/query-aggregate-unordered
branch
2 times, most recently
from
86c70cb
to
ad568d7
Compare
teo-tsirpanis
force-pushed
the
teo/query-aggregate-unordered
branch
from
ad568d7
to
d7be842
Compare
teo-tsirpanis
changed the title
KiterLuc
reviewed
Sep 2, 2024
tiledb/sm/query/query.h
Outdated
| /** | ||
| * Return the layout that will be used to execute the query. | ||
| * | ||
| * This is usually set by the user but cen be overridden by TileDB in cases |
There was a problem hiding this comment.
Suggested change
| * This is usually set by the user but cen be overridden by TileDB in cases | |
| * This is usually set by the user but can be overridden by TileDB in cases |
KiterLuc
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-53286
If the user has not set a query layout, it will default to row-major, which will use the legacy reader on sparse arrays, and fail if aggregates were specified.
However, if only aggregates are specified and no regular data buffers, the layout doesn't matter and we can transparently switch to the much more efficient unordered layout.
TYPE: IMPROVEMENT
DESC: Fix read queries on sparse arrays where only aggregates are requested and no layout is specified.