Fix crash getting file size on non existent blob on Azure. #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #44026: Crash in Azure getting a file_size via VFS for a blob that doesn't exist.. |
|
[sc-4269] |
|
@robertbindar any clue what's failing in CI? |
|
@KiterLuc let me check |
robertbindar
force-pushed
the
rbin/ch44026/file_size_crash
branch
from
75e24ef to
2763397
Compare
robertbindar
force-pushed
the
rbin/ch44026/file_size_crash
branch
from
2763397 to
82edb78
Compare
KiterLuc
reviewed
Apr 1, 2024
| @@ -442,6 +442,19 @@ TEMPLATE_LIST_TEST_CASE("VFS: File I/O", "[vfs][uri][file_io]", AllBackends) { | |||
| Config config = set_config_params(disable_multipart, max_parallel_ops); | |||
| VFS vfs{&g_helper_stats, &compute_tp, &io_tp, config}; | |||
|
|
|||
| // Getting file_size on a nonexistent blob shouldn't crash on Azure | |||
There was a problem hiding this comment.
We have follow up work for this. 44271
KiterLuc
approved these changes
Apr 1, 2024
KiterLuc
changed the title
ihnorton
added
backport release-2.20
and removed
backport release-2.21
backport release-2.20
labels
KiterLuc
pushed a commit
that referenced
this pull request
Apr 3, 2024
This fixes getting a file size on azure when the blob is non existent. We would end up not getting an error and trying to read an empty array. --- TYPE: BUG DESC: Fix crash getting file size on non existent blob on Azure. (cherry picked from commit 0c50eeb)
KiterLuc
added a commit
that referenced
this pull request
Apr 3, 2024
…lob on Azure. (#4836) (#4853) Backport 0c50eeb from #4836. --- TYPE: BUG DESC: Fix crash getting file size on non existent blob on Azure. Co-authored-by: Robert Bindar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes getting a file size on azure when the blob is non existent. We would end up not getting an error and trying to read an empty array.
TYPE: BUG
DESC: Fix crash getting file size on non existent blob on Azure.