Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move filter pipeline tests out of tiledb_unit #4797

Merged
merged 11 commits into from
Mar 12, 2024
Merged

Move filter pipeline tests out of tiledb_unit #4797

merged 11 commits into from
Mar 12, 2024

Conversation

jp-dark
Copy link
Contributor

@jp-dark jp-dark commented Mar 7, 2024

  • Move unit filter pipeline tests from tiledb_unit to unit tests in tiledb/sm/filter/tests.
  • Rename file with remaining C++ integration tests.

TYPE: NO_HISTORY

@jp-dark jp-dark requested a review from KiterLuc March 7, 2024 16:56
@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #38324: Move filter pipeline tests from tiledb_unit to sm/filter/test.

@KiterLuc KiterLuc requested a review from ypatia March 8, 2024 18:41
@KiterLuc
Copy link
Contributor

@ypatia follow up with @jp-dark as this is a lot of code movement with limited changes.

ypatia
ypatia approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@ypatia ypatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tidying up those tests!

tiledb/sm/filter/test/filter_test_support.cc Outdated Show resolved Hide resolved
tiledb/sm/filter/test/unit_run_filter_pipeline.cc Outdated Show resolved Hide resolved
test/src/cpp-integration-filter-pipeline.cc Outdated Show resolved Hide resolved
@jp-dark @ypatia
Update copyright date
e8e8517 
Co-authored-by: Ypatia Tsavliri <[email protected]>
@KiterLuc KiterLuc merged commit fdb5674 into dev Mar 12, 2024
57 checks passed
@KiterLuc KiterLuc deleted the dark/sc-38324 branch March 12, 2024 21:04
robertbindar pushed a commit that referenced this pull request Mar 22, 2024
@jp-dark @ypatia @robertbindar
Move filter pipeline tests out of tiledb_unit (#4797)
0399f72 
* Move unit filter pipeline tests from tiledb_unit to unit tests in
tiledb/sm/filter/tests.
* Rename file with remaining C++ integration tests.

---
TYPE: NO_HISTORY

---------

Co-authored-by: Ypatia Tsavliri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypatia ypatia ypatia approved these changes

@KiterLuc KiterLuc Awaiting requested review from KiterLuc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jp-dark @KiterLuc @ypatia