Move the Hadoop header files to hdfs_filesystem.cc.
#4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
approved these changes
Mar 7, 2024
|
Very nice, looks generally better than my solution :) |
|
This pull request has been linked to Shortcut Story #42734: Cannot build unit tests when HDFS is enabled.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-42734
This PR moves including
hadoop/hdfs.hfromhdfs_filesystem.hto thehdfs_filesystem.ccimplementation file. Due to the current structure of the code,hdfs_filesystem.his included byvfs.h, which is included by many files, resulting in having to specify the path tohadoop/hdfs.hin all dependents, such as unit tests. A similar change was recently made for the GCS SDK in #4777.Thanks to @rroelke for finding this issue. Validated by successfully building all unit tests touched by #4793 with HDFS enabled.
TYPE: BUILD
DESC: Fix compiling unit tests when HDFS is enabled.