Prevent bugs in memory_type_to_str #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first PR for this either had a weird merge conflict or I totally whiffed on the commit. Regardless, the point was to remove the default switch case so that the compiler will enforce a switch case for every MemoryType and MemoryTrackerType.
|
This pull request has been linked to Shortcut Story #42456: Add missing MemoryTrackerType to string switch case.. |
KiterLuc
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR for this either had a weird merge conflict or I totally whiffed on the commit. Regardless, the point was to remove the default switch case so that the compiler will enforce a switch case for every MemoryType and MemoryTrackerType.
TYPE: NO_HISTORY
DESC: Actually fix missing memory_tracker_type_to_str