Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation for memory measurement: FilteredData and FilteredDataBlock. #4779

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

bekadavis9
Copy link
Contributor

@bekadavis9 bekadavis9 commented Mar 1, 2024

Add tdb::pmr::list wrapper as an alias for std::list. Instrument classes FilteredData and FilteredDataBlock for memory measurement.


TYPE: NO_HISTORY
DESC: Instrumentation for memory measurement: FilteredData and FilteredDataBlock. Addition of tdb::pmr::list wrapper.

@bekadavis9 bekadavis9 requested a review from KiterLuc March 1, 2024 21:47
@KiterLuc KiterLuc force-pushed the rd/instrumentation-filtered_data branch from b3f11d2 to e838f29 Compare March 4, 2024 10:01
@bekadavis9 bekadavis9 force-pushed the rd/instrumentation-filtered_data branch from 30873da to 6a31a56 Compare March 5, 2024 16:19
Copy link

@bekadavis9 bekadavis9 marked this pull request as ready for review March 5, 2024 17:48
Copy link
Contributor

@KiterLuc KiterLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @davisp can you glance quickly to make sure I didn't miss anything?

@KiterLuc KiterLuc requested a review from davisp March 7, 2024 16:52
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a gnarly diff in dense_reader.cc due to clang-format rewriting things fairly drastically. Though ended up just comparing by eye against dev and I'm convinced. I've just got the one minor question on the lambda argument.

+1 though. Good work!

tiledb/sm/query/readers/dense_reader.cc Outdated Show resolved Hide resolved
@davisp davisp merged commit cfe5d97 into dev Mar 8, 2024
57 checks passed
@davisp davisp deleted the rd/instrumentation-filtered_data branch March 8, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants