Instrument Metadata class for memory measurement. #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #40788: Instrument Metadata class for memory measurement. |
davisp
requested changes
Feb 22, 2024
bekadavis9
force-pushed
the
rd/memory-metadata
branch
2 times, most recently
from
4474b82 to
f709bd9
Compare
davisp
requested changes
Feb 29, 2024
davisp
approved these changes
Mar 1, 2024
bekadavis9
force-pushed
the
rd/memory-metadata
branch
from
6998a44 to
db95636
Compare
KiterLuc
added a commit
that referenced
this pull request
Mar 21, 2024
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client. --- TYPE: BUG DESC: Do not load group metadata when getting it from REST.
KiterLuc
added a commit
that referenced
this pull request
Mar 21, 2024
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client. --- TYPE: BUG DESC: Do not load group metadata when getting it from REST.
KiterLuc
added a commit
that referenced
this pull request
Mar 21, 2024
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client. --- TYPE: BUG DESC: Do not load group metadata when getting it from REST.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client. --- TYPE: BUG DESC: Do not load group metadata when getting it from REST. (cherry picked from commit 07b26fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
tdb::pmr::mapwrapper as an alias forstd::map. Migrate classMetadatato use scoped allocators for memory tracking.TYPE: NO_HISTORY
DESC: Instrument Metadata class for memory measurement. Addition of tdb::pmr::map wrapper.