Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate std::prm memory tracking for class ArraySchemaEvolution. #4736

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Integrate std::prm memory tracking for class ArraySchemaEvolution. #4736

merged 4 commits into from
Mar 1, 2024

Conversation

abigalekim
Copy link
Contributor

@abigalekim abigalekim commented Feb 16, 2024 •
edited by KiterLuc
Loading

All member vector variables of the ArraySchemaEvolution class have PMR tracking.

TYPE: NO_HISTORY
DESC: Integrate std::prm memory tracking for class ArraySchemaEvolution.

@abigalekim abigalekim requested a review from davisp February 16, 2024 08:11
@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #41175: Integrate std::prm memory tracking for class ArraySchemaEvolution..

davisp
davisp requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a quick skim and it appears to be on the right track. I think that bad include was the only thing I saw.

tiledb/sm/array_schema/array_schema_evolution.h Outdated Show resolved Hide resolved
@abigalekim abigalekim requested a review from davisp February 18, 2024 09:35
davisp
davisp reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll approve once CI passes after the ArraySchema PR is merged.

test/src/unit-enumerations.cc Outdated Show resolved Hide resolved
@abigalekim abigalekim force-pushed the abigalekim/sc-41175/pmr-memory-tracking-arrayschemaevolution branch from 2d6a163 to d8f8101 Compare February 27, 2024 22:58
@abigalekim abigalekim requested a review from davisp February 28, 2024 21:52
davisp
davisp approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@KiterLuc KiterLuc merged commit 2fcf371 into dev Mar 1, 2024
57 checks passed
@KiterLuc KiterLuc deleted the abigalekim/sc-41175/pmr-memory-tracking-arrayschemaevolution branch March 1, 2024 07:57
davisp pushed a commit to davisp/TileDB that referenced this pull request Mar 3, 2024
@abigalekim @davisp
Integrate std::prm memory tracking for class ArraySchemaEvolution. (T…
5d00114 
…ileDB-Inc#4736)

All member vector variables of the ArraySchemaEvolution class have PMR
tracking.

---
TYPE: NO_HISTORY
DESC: Integrate std::prm memory tracking for class
`ArraySchemaEvolution`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisp davisp davisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abigalekim @davisp @KiterLuc