Integrate std::prm memory tracking for class Enumeration.

[abigalekim]

All member vector variables of the Enumeration class have PMR tracking.

---

TYPE: NO_HISTORY
DESC: Integrate std::prm memory tracking for class Enumeration.

[shortcut-integration]

This pull request has been linked to Shortcut Story #40878: Integrate std::prm memory tracking for class Enumeration..

[davisp]

Few minor changes I spotted on a quick skim. Same as for the ArraySchema PR, don't feel like you have to make those argument ordering changes yourself if you don't feel like it.

[davisp]

One minor nit. Other than that I'll approve this as soon as the ArrarySchema PR is merged.

[davisp]

Ope, I caught one last thing. When we're loading enumerations normally through the Array class APIs, we're inadvertently using the REST Client's MemoryTracker instead of the Array tracker. For this function:

TileDB/tiledb/sm/rest/rest_client.h

Lines 252 to 257 in 9883b34

	std::vector<shared_ptr<const Enumeration>> post_enumerations_from_rest(
	const URI& uri,
	uint64_t timestamp_start,
	uint64_t timestamp_end,
	Array* array,
	const std::vector<std::string>& enumeration_names);

  std::vector<shared_ptr<const Enumeration>> post_enumerations_from_rest(
      const URI& uri,
      uint64_t timestamp_start,
      uint64_t timestamp_end,
      Array* array,
      const std::vector<std::string>& enumeration_names,
      shared_ptr<MemoryTracker> memory_tracker = nullptr);

Then in the body of that function we can just do:

if (!memory_tracker) {
  memory_tracker = memory_tracker_;
}

That way it won't affect anything other than where we specify which MemoryTracker at the call site.

Then we just have to add the memory_tracker_ argument here:

https://github.com/TileDB-Inc/TileDB/blob/dev/tiledb/sm/array/array.cc#L591-L596

[abigalekim]

Ope, I caught one last thing. When we're loading enumerations normally through the Array class APIs, we're inadvertently using the REST Client's MemoryTracker instead of the Array tracker. For this function:

TileDB/tiledb/sm/rest/rest_client.h

Lines 252 to 257 in 9883b34

	std::vector<shared_ptr<const Enumeration>> post_enumerations_from_rest(
	const URI& uri,
	uint64_t timestamp_start,
	uint64_t timestamp_end,
	Array* array,
	const std::vector<std::string>& enumeration_names);

  std::vector<shared_ptr<const Enumeration>> post_enumerations_from_rest(
      const URI& uri,
      uint64_t timestamp_start,
      uint64_t timestamp_end,
      Array* array,
      const std::vector<std::string>& enumeration_names,
      shared_ptr<MemoryTracker> memory_tracker = nullptr);

Then in the body of that function we can just do:

if (!memory_tracker) {
  memory_tracker = memory_tracker_;
}

That way it won't affect anything other than where we specify which MemoryTracker at the call site.

Then we just have to add the memory_tracker_ argument here:

https://github.com/TileDB-Inc/TileDB/blob/dev/tiledb/sm/array/array.cc#L591-L596

Fixed this comment!

[davisp]

Nice work!