Integrate std::prm memory tracking for class Enumeration.
#4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deleted default constructor of class tiledb::sm::ArraySchema - Changed copy_with_new_memory_tracker to clone - Deleted constructor with pmr vector. Problems remaining: - had to make copy constructor public since a protected one does not work with our version of make_shared.
[SC-40555](https://app.shortcut.com/tiledb-inc/story/40555/lazily-initialize-the-azure-sdk) The other two cloud VFSes already lazily initialize their SDK client, this PR does it for Azure as well. Validated by locally running the Azure tests in Azurite. --- TYPE: IMPROVEMENT DESC: Lazily initialize the Azure SDK client. --------- Co-authored-by: KiterLuc <[email protected]>
This allows easy access for readers and writers to the query memory tracker. Originally written as part of the Tile instrumentation PR, this is just an extraction so that it can unblock other work in adding other measurements. --- TYPE: NO_HISTORY DESC: Add the query_memory_tracker
--- DESC: Don't run Build-Release workflow on every PR, reduce CI overhead TYPE: NO_HISTORY
New behavior doesn't delete masked objects. So check after the first deletion if we need to remove anything that was uncovered. --- TYPE: BUG DESC: Fix bug with new minio behavior
* Update unit tests to use new testing infrastructure. * Remove unneeded test infrastructure from tiledb_unit. --- TYPE: NO_HISTORY Co-authored-by: Julia Dark <>
--- TYPE: NO_HISTORY DESC: Update dev HISTORY with 2.20.0 content.
This PR adds functionality to create issue when release workflow fails. This is how the issue will look: dudoslav#1 --- TYPE: NO_HISTORY DESC: Create issue if release workflow fails --------- Co-authored-by: Theodore Tsirpanis <[email protected]>
|
This pull request has been linked to Shortcut Story #40878: Integrate std::prm memory tracking for class |
abigalekim
force-pushed
the
pd/abigalekim/sc-40462/pmr-memory-tracking-arrayschema
branch
from
a0b1fbe
to
ee51025
Compare
abigalekim
deleted the
abigalekim/sc-40878/pmr-memory-tracking-enumeration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All member vector variables of the enumeration class have PMR tracking.
TYPE: NO_HISTORY
DESC: Integrate std::prm memory tracking for class
Enumeration.